tree ac390bbbe5dfd9d693e9dd4637b952d41d91d50e
parent 1ab76dd956042019aabbfc2a04dc6a3101ce1a02
author Thayne McCombs <thayne@lucidchart.com> 1609913409 -0700
committer Willy Tarreau <w@1wt.eu> 1609921155 +0100
encoding latin1

BUG/MEDIUM: server: srv_set_addr_desc() crashes when a server has no address

GitHub Issue #1026 reported a crash during configuration check for the
following example config:

    backend 0
    server 0 0
    server 0 0

HAProxy crashed in srv_set_addr_desc() due to a NULL pointer dereference
caused by `sa2str` returning NULL for an `AF_UNSPEC` address (`0`).

Check to make sure the address key is non-null before using it for
comparison or inserting it into the tree.

The crash was introduced in commit 92149f9a8 ("MEDIUM: stick-tables: Add
srvkey option to stick-table") which not in any released version so no
backport is needed.

Cc: Tim Duesterhus <tim@bastelstu.be>