tree bd4b37150a92b76266ed28f6caf37588077a7ac1
parent 83dd38e602e77c5305a7b45cf1400099d0178d04
author Aurelien DARRAGON <adarragon@haproxy.com> 1683794089 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1686034423 +0200

BUG/MINOR: http_rules: fix errors paths in http_parse_redirect_rule()

http_parse_redirect_rule() doesn't perform enough checks around NULL
returning allocating functions.

Moreover, existing error paths don't perform cleanups. This could lead to
memory leaks.

Adding a few checks and a cleanup path to ensure memory errors are
properly handled and that no memory leaks occurs within the function
(already allocated structures are freed on error path).

It should partially fix GH #2130.

This patch depends on ("MINOR: proxy: add http_free_redirect_rule() function")

This could be backported up to 2.4. The patch is also relevant for
2.2 but "MINOR: proxy: add http_free_redirect_rule() function" would
need to be adapted first.

==

Backport notes:

-> For 2.2 only:

Replace:

    (strcmp(args[cur_arg], "drop-query") == 0)

with:

    (!strcmp(args[cur_arg],"drop-query"))

-> For 2.2 and 2.4:

Replace:

    "expects 'code', 'prefix', 'location', 'scheme', 'set-cookie', 'clear-cookie', 'drop-query', 'ignore-empty' or 'append-slash' (was '%s')",

with:

    "expects 'code', 'prefix', 'location', 'scheme', 'set-cookie', 'clear-cookie', 'drop-query' or 'append-slash' (was '%s')",

(cherry picked from commit 5313570605fdcf471e7286a68432830a2a1ca72f)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 35b2d25318c735b61872a9652d7f2f3fba0ca4d3)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 443763835aa7bc2fe7783c925e4ea6550d30f6fc)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>