BUG/MINOR: threads: move declaration of capabilities to config.h
In commit f161d0f51 ("BUG/MINOR: pools/threads: don't ignore DEBUG_UAF
on double-word CAS capable archs") I moved some defines and accidently
messed up with lockfree pools. The problem is that the HA_HAVE_CAS_DW
macro is not defined anymore where the CONFIG_HAP_LOCKLESS_POOLS macro
is set, so this fix implicitly disabled lockfree pools.
This patch fixes this by moving the capabilities definition to config.h
(probably that we'd benefit from having an "arch.h" file to declare the
capabilities offered by the architecture). In a test on a 12-core machine,
we used to measure 19s spent in the pool lock for 1M requests without
this patch, and 0 with it so that's definitely a net saving.
No backport is required, this is only for 1.9.
diff --git a/include/common/hathreads.h b/include/common/hathreads.h
index 01b2181..1f3fe8d 100644
--- a/include/common/hathreads.h
+++ b/include/common/hathreads.h
@@ -816,8 +816,7 @@
#endif /* DEBUG_THREAD */
#ifdef __x86_64__
-#define HA_HAVE_CAS_DW 1
-#define HA_CAS_IS_8B
+
static __inline int
__ha_cas_dw(void *target, void *compare, const void *set)
{
@@ -855,7 +854,7 @@
}
#elif defined(__arm__) && (defined(__ARM_ARCH_7__) || defined(__ARM_ARCH_7A__))
-#define HA_HAVE_CAS_DW 1
+
static __inline void
__ha_barrier_load(void)
{
@@ -896,8 +895,6 @@
}
#elif defined (__aarch64__)
-#define HA_HAVE_CAS_DW 1
-#define HA_CAS_IS_8B
static __inline void
__ha_barrier_load(void)