CLEANUP: tools: Crash if inet_ntop fails due to ENOSPC in sa2str
This is impossible, because we pass a destination buffer that is appropriately
sized to hold an IPv6 address.
This is related to GitHub issue #1599.
diff --git a/src/tools.c b/src/tools.c
index 79d1d5c..4ecbdc4 100644
--- a/src/tools.c
+++ b/src/tools.c
@@ -1375,7 +1375,10 @@
default:
return NULL;
}
- inet_ntop(addr->ss_family, ptr, buffer, sizeof(buffer));
+ if (inet_ntop(addr->ss_family, ptr, buffer, sizeof(buffer)) == NULL) {
+ BUG_ON(errno == ENOSPC);
+ return NULL;
+ }
if (map_ports)
return memprintf(&out, "%s:%+d", buffer, port);
else