tree 94557c46595a8c85f7073be38530cb45219f9003
parent b0dfd099c56b8f8fd46686120a6cf1598bd5e470
author Amaury Denoyelle <adenoyelle@haproxy.com> 1646732915 +0100
committer Amaury Denoyelle <adenoyelle@haproxy.com> 1646746592 +0100

BUG/MEDIUM: quic: do not drop packet on duplicate stream/decoding error

Change the return value to success in qc_handle_bidi_strm_frm for two
specific cases :
* if STREAM frame is an already received offset
* if application decoding failed

This ensures that the packet is not dropped and properly acknowledged.
Previous to this fix, the return code was set to error which prevented
the ACK to be generated.

The impact of the bug might be noticeable in environment with packet
loss and retransmission. Due to haproxy not generating ACK for packets
containing STREAM frames with already received offset, the client will
probably retransmit them again, which will worsen the network
transmission.