BUG/MINOR: http-htx: Fix error handling during parsing http replies
When an error is triggered during arguments parsing of an http reply (for
instance, from a "return" rule), while a log-format body was expected but
not evaluated yet, HAproxy crashes when the body log-format string is
released because it was not properly initialized.
The list used for the log-format string must be initialized earlier.
This patch should fix the issue #1925. It must be backported as far as 2.2.
(cherry picked from commit 5a3d9a77e20a66796357627b1dd807a1b22603a5)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit de3a7ba373a2ab39c810d1d490f89084bf3aa7e7)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 7166448d07d6c2bdb7393dbf60e5d79374b03143)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
diff --git a/src/http_htx.c b/src/http_htx.c
index e97141c..bb9474c 100644
--- a/src/http_htx.c
+++ b/src/http_htx.c
@@ -1565,6 +1565,7 @@
fd = -1;
obj[objlen] = '\0';
reply->type = HTTP_REPLY_LOGFMT;
+ LIST_INIT(&reply->body.fmt);
cur_arg++;
}
else if (strcmp(args[cur_arg], "lf-string") == 0) {
@@ -1581,6 +1582,7 @@
obj = strdup(args[cur_arg]);
objlen = strlen(args[cur_arg]);
reply->type = HTTP_REPLY_LOGFMT;
+ LIST_INIT(&reply->body.fmt);
cur_arg++;
}
else if (strcmp(args[cur_arg], "hdr") == 0) {