BUG/MINOR: ssl: Clear the ckch instance when deleting a crt-list line
When deleting a crt-list line through a "del ssl crt-list" call on the
CLI, we ended up free'ing the corresponding ckch instances without fully
clearing their contents. It left some dangling references on other
objects because the attache SSL_CTX was not deleted, as well as all the
ex_data referenced by it (OCSP responses for instance).
This patch can be backported up to branch 2.4.
(cherry picked from commit 23cab33b67dd9dc76de936f47dfa23b1a8ee40e5)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit f41ddcb765d962dec978ef454d700456ecb69491)
Signed-off-by: Willy Tarreau <w@1wt.eu>
(cherry picked from commit 6ebec4b4112e1afa41843bb9a730406081d07223)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 92a860a00940aa5dcd5a282b78f0d6280bb586b3)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 96c1ab7e5f23938c10f69469f432300177297470)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
diff --git a/src/ssl_crtlist.c b/src/ssl_crtlist.c
index 894a690..7cd4762 100644
--- a/src/ssl_crtlist.c
+++ b/src/ssl_crtlist.c
@@ -1442,7 +1442,7 @@
}
HA_RWLOCK_WRUNLOCK(SNI_LOCK, &inst->bind_conf->sni_lock);
LIST_DELETE(&inst->by_ckchs);
- free(inst);
+ ckch_inst_free(inst);
}
crtlist_free_filters(entry->filters);