tree 57cdf531168a13748dc26d704c359a4c923503e2
parent 4f09ec812adbd9336cddc054660a7fb5cd54b459
author Christopher Faulet <cfaulet@haproxy.com> 1560934238 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1560945357 +0200

BUG/MEDIUM: lb_fwlc: Don't test the server's lb_tree from outside the lock

In the function fwlc_srv_reposition(), the server's lb_tree is tested from
outside the lock. So it is possible to remove it after the test and then call
eb32_insert() in fwlc_queue_srv() with a NULL root pointer, which is
invalid. Moving the test in the scope of the lock fixes the bug.

This issue was reported on Github, issue #126.

This patch must be backported to 2.0, 1.9 and 1.8.