commit 1a58aca84ed899da3b9b28445156ba1f5f1b9005
author Amaury Denoyelle <adenoyelle@haproxy.com> Fri Jan 22 16:47:46 2021 +0100
committer Amaury Denoyelle <adenoyelle@haproxy.com> Fri Feb 12 12:33:05 2021 +0100
tree 7630f16149f89ac578cd15874110e5126c268289
parent 81c6f76d3ebefa95108eeb2fcf7aae042253810b

MINOR: connection: use the srv pointer for the srv conn hash

The pointer of the target server is used as a first parameter for the
server connection hash calcul. This prevents the hash to be null when no
specific parameters are present, and can serve as a simple defense
against an attacker trying to reuse a non-conform connection.

src/connection.c

diff --git a/src/connection.c b/src/connection.c
index f5dbffb..3656b36 100644
--- a/src/connection.c
+++ b/src/connection.c
@@ -1421,6 +1421,8 @@
 
 	buf = trash.area;
 
+	conn_hash_update(buf, &idx, &params->srv, sizeof(params->srv), &hash_flags, 0);
+
 	hash = conn_hash_digest(buf, idx, hash_flags);
 	return hash;
 }