tree 95033336bc2f08a72643227b9b35b3b5449eb3da
parent 35bb0e59efa1a3bc4cb295826079cbb40f73e5fd
author William Lallemand <wlallemand@haproxy.org> 1645197192 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1645792103 +0100

BUG/MINOR: tools: url2sa reads ipv4 too far

The url2sa implementation is inconsitent when parsing an IPv4, indeed
url2sa() takes a <ulen> as a parameter where the call to url2ipv4() takes
a null terminated string. Which means url2ipv4 could try to read more
that it is supposed to.

This function is only used from a buffer so it never reach a unallocated
space. It can only cause an issue when used from the httpclient which
uses it with an ist.

This patch fixes the issue by copying everything in the trash and
null-terminated it.

Must be backported in all supported version.

(cherry picked from commit 8a91374487e13cf139ab36e483163a21ebdc6f4e)
Signed-off-by: William Lallemand <wlallemand@haproxy.org>
(cherry picked from commit 597e436053258d71e57381e14e1fae10220630bc)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>