tree 4e7d1d6f8fb775dbc7364fc65d34cb10b145f2df
parent ff9c9140f4da4f14bef8c9a5955f9453d0f26c60
author Christopher Faulet <cfaulet@haproxy.com> 1549552406 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1549571038 +0100

BUG/MAJOR: spoe: Don't try to get agent config during SPOP healthcheck

During SPOP healthchecks, a dummy appctx is used to create the HAPROXY-HELLO
frame and then to parse the AGENT-HELLO frame. No agent are attached to it. So
it is important to not rely on an agent during these stages. When HAPROXY-HELLO
frame is created, there is no problem, all accesses to an agent are
guarded. This is not true during the parsing of the AGENT-HELLO frame. Thus, it
is possible to crash HAProxy with a SPOA declaring the async or the pipelining
capability during a healthcheck.

This patch must be backported to 1.9 and 1.8.