MINOR: ssl: Reinsert updated ocsp response later in tree in case of http error
When updating an OCSP response, in case of HTTP error (host unreachable
for instance) we do not want to reinsert the entry at the same place in
the update tree otherwise we might retry immediately the update of the
same response. This patch adds an arbitrary 1min time to the next_update
of a response in such a case.
After an HTTP error, instead of waking the update task up after an
arbitrary 10s time, we look for the first entry of the update tree and
sleep for the apropriate time.
diff --git a/src/ssl_ocsp.c b/src/ssl_ocsp.c
index 8f0e5ff..cce0509 100644
--- a/src/ssl_ocsp.c
+++ b/src/ssl_ocsp.c
@@ -186,6 +186,7 @@
#define SSL_OCSP_UPDATE_DELAY_MAX 60*60 /* 1H */
#define SSL_OCSP_UPDATE_DELAY_MIN 5*60 /* 5 minutes */
#define SSL_OCSP_UPDATE_MARGIN 60 /* 1 minute */
+#define SSL_OCSP_HTTP_ERR_REPLAY 60 /* 1 minute */
/* This function starts to check if the OCSP response (in DER format) contained
* in chunk 'ocsp_response' is valid (else exits on error).
@@ -847,6 +848,22 @@
ssl_ocsp_task_ctx.cur_ocsp = NULL;
}
+static inline void ssl_ocsp_set_next_update(struct certificate_ocsp *ocsp)
+{
+ int update_margin = (ocsp->expire >= SSL_OCSP_UPDATE_MARGIN) ? SSL_OCSP_UPDATE_MARGIN : 0;
+
+ ocsp->next_update.key = MIN(now.tv_sec + SSL_OCSP_UPDATE_DELAY_MAX,
+ ocsp->expire - update_margin);
+
+ /* An already existing valid OCSP response that expires within less than
+ * SSL_OCSP_UPDATE_DELAY_MIN or has no 'Next Update' field should not be
+ * updated more than once every 5 minutes in order to avoid continuous
+ * update of the same response. */
+ if (b_data(&ocsp->response))
+ ocsp->next_update.key = MAX(ocsp->next_update.key,
+ now.tv_sec + SSL_OCSP_UPDATE_DELAY_MIN);
+}
+
/*
* Insert a certificate_ocsp structure into the ocsp_update_tree tree, in which
* entries are sorted by absolute date of the next update. The next_update key
@@ -859,18 +876,34 @@
*/
int ssl_ocsp_update_insert(struct certificate_ocsp *ocsp)
{
- int update_margin = (ocsp->expire >= SSL_OCSP_UPDATE_MARGIN) ? SSL_OCSP_UPDATE_MARGIN : 0;
+ /* Set next_update based on current time and the various OCSP
+ * minimum/maximum update times.
+ */
+ ssl_ocsp_set_next_update(ocsp);
- ocsp->next_update.key = MIN(now.tv_sec + SSL_OCSP_UPDATE_DELAY_MAX,
- ocsp->expire - update_margin);
+ HA_SPIN_LOCK(OCSP_LOCK, &ocsp_tree_lock);
+ eb64_insert(&ocsp_update_tree, &ocsp->next_update);
+ HA_SPIN_UNLOCK(OCSP_LOCK, &ocsp_tree_lock);
- /* An already existing valid OCSP response that expires within less than
- * SSL_OCSP_UPDATE_DELAY_MIN or has no 'Next Update' field should not be
- * updated more than once every 5 minutes in order to avoid continuous
- * update of the same response. */
- if (b_data(&ocsp->response))
- ocsp->next_update.key = MAX(ocsp->next_update.key,
- now.tv_sec + SSL_OCSP_UPDATE_DELAY_MIN);
+ return 0;
+}
+
+/*
+ * Reinsert an entry in the update tree. The entry's next update time can not
+ * occur before now+SSL_OCSP_HTTP_ERR_REPLAY.
+ * This is supposed to be used in case of http error (ocsp responder unreachable
+ * for instance). This ensures that the entry does not get reinserted at the
+ * beginning of the tree every time.
+ */
+int ssl_ocsp_update_insert_after_error(struct certificate_ocsp *ocsp)
+{
+ /* Set next_update based on current time and the various OCSP
+ * minimum/maximum update times.
+ */
+ ssl_ocsp_set_next_update(ocsp);
+
+ if (ocsp->next_update.key < now.tv_sec + SSL_OCSP_HTTP_ERR_REPLAY)
+ ocsp->next_update.key = now.tv_sec + SSL_OCSP_HTTP_ERR_REPLAY;
HA_SPIN_LOCK(OCSP_LOCK, &ocsp_tree_lock);
eb64_insert(&ocsp_update_tree, &ocsp->next_update);
@@ -945,7 +978,7 @@
*/
static struct task *ssl_ocsp_update_responses(struct task *task, void *context, unsigned int state)
{
- unsigned int next_wakeup;
+ unsigned int next_wakeup = 0;
struct eb64_node *eb;
struct certificate_ocsp *ocsp;
struct httpclient *hc = NULL;
@@ -954,10 +987,6 @@
OCSP_CERTID *certid = NULL;
struct ssl_ocsp_task_ctx *ctx = &ssl_ocsp_task_ctx;
- /* This arbitrary 10s time should only be used when an error occurred
- * during an ocsp response processing. */
- next_wakeup = 10000;
-
if (ctx->cur_ocsp) {
/* An update is in process */
ocsp = ctx->cur_ocsp;
@@ -1137,12 +1166,22 @@
http_error:
/* Reinsert certificate into update list so that it can be updated later */
if (ocsp)
- ssl_ocsp_update_insert(ocsp);
+ ssl_ocsp_update_insert_after_error(ocsp);
if (hc)
httpclient_stop_and_destroy(hc);
/* Release the reference kept on the updated ocsp response. */
ssl_sock_free_ocsp(ctx->cur_ocsp);
+ HA_SPIN_LOCK(OCSP_LOCK, &ocsp_tree_lock);
+ /* Set next_wakeup to the new first entry of the tree */
+ eb = eb64_first(&ocsp_update_tree);
+ if (eb) {
+ if (eb->key > now.tv_sec)
+ next_wakeup = (eb->key - now.tv_sec)*1000;
+ else
+ next_wakeup = 0;
+ }
+ HA_SPIN_UNLOCK(OCSP_LOCK, &ocsp_tree_lock);
ctx->cur_ocsp = NULL;
ctx->hc = NULL;
ctx->flags = 0;