tree eb4ff35e48ee7adfa004979a38459326af8433a7
parent 445b2b7c52a13678241a190c4ff52e77a09ef0a6
author Christopher Faulet <cfaulet@haproxy.com> 1564646969 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1564652506 +0200

BUG/MEDIUM: lb-chash: Ensure the tree integrity when server weight is increased

When the server weight is increased in consistant hash, extra nodes have to be
allocated. So a realloc() is performed on the nodes array of the server. the
previous commit 962ea7732 ("BUG/MEDIUM: lb-chash: Remove all server's entries
before realloc() to re-insert them after") have fixed the size used during the
realloc() to avoid segfaults. But another bug remains. After the realloc(), the
memory area allocated for the nodes array may change, invalidating all node
addresses in the chash tree.

So, to fix the bug, we must remove all server's entries from the chash tree
before the realloc to insert all of them after, old nodes and new ones. The
insert will be automatically handled by the loop at the end of the function
chash_queue_dequeue_srv().

Note that if the call to realloc() failed, no new entries will be created for
the server, so the effective server weight will be unchanged.

This issue was reported on Github (#189).

This patch must be backported to all versions since the 1.6.

(cherry picked from commit 0a52c17f819a5b0a17718b605bdd990b9e2b58e6)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>