tree 0ed42b4929b87373da5b83f1f75a4540314ebfb4
parent 750beb7f3f843ef6af3913896abcc62cc49993f0
author Amaury Denoyelle <adenoyelle@haproxy.com> 1620638614 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1623914840 +0200

BUG/MINOR: http_fetch: fix possible uninit sockaddr in fetch_url_ip/port

Check the return value of url2sa in smp_fetch_url_ip/port. If negative,
the address result is uninitialized and the sample fetch is aborted.
Also, the sockaddr is prelimiary zero'ed before calling url2sa to ensure
that it is not used by upper functions even if the sample returns 0.

Without the check, the value returned by the url_ip/url_port fetches is
unspecified. This can be triggered with the following curl :
$ curl -iv --request-target "xxx://127.0.0.1:20080/" http://127.0.0.1:20080/

This should be backported to all stable branches. However, note that
between the 1.8 and 2.0, the targetted functions have been extracted
from proto_http.c to http_fetch.c.

This should fix in part coverity report from the github issue #1244.

(cherry picked from commit c89d5337ee5064091ceab7b2d967f99071dc39eb)
Signed-off-by: Willy Tarreau <w@1wt.eu>
(cherry picked from commit 6e5795d610be8491525b781b53ef474fbe4a0341)
Signed-off-by: Willy Tarreau <w@1wt.eu>
(cherry picked from commit f4edd378d2c6bd8e3ebcaf29204cdade7f8c8266)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>