BUG/MINOR: httpclient: check if hdr_num is not 0
Check if hdr_num is not 0 before allocating or copying the headers to
the hc->hdrs space.
diff --git a/src/http_client.c b/src/http_client.c
index 89d7d76..257c2c0 100644
--- a/src/http_client.c
+++ b/src/http_client.c
@@ -533,15 +533,17 @@
hdr_num++;
}
- /* alloc and copy the headers in the httpclient struct */
- hc->res.hdrs = calloc((hdr_num + 1), sizeof(*hc->res.hdrs));
- if (!hc->res.hdrs)
- goto end;
- memcpy(hc->res.hdrs, hdrs, sizeof(struct http_hdr) * (hdr_num + 1));
+ if (hdr_num) {
+ /* alloc and copy the headers in the httpclient struct */
+ hc->res.hdrs = calloc((hdr_num + 1), sizeof(*hc->res.hdrs));
+ if (!hc->res.hdrs)
+ goto end;
+ memcpy(hc->res.hdrs, hdrs, sizeof(struct http_hdr) * (hdr_num + 1));
- /* caller callback */
- if (hc->ops.res_headers)
- hc->ops.res_headers(hc);
+ /* caller callback */
+ if (hc->ops.res_headers)
+ hc->ops.res_headers(hc);
+ }
/* if there is no HTX data anymore and the EOM flag is
* set, leave (no body) */