MEDIUM: connection: panic when calling FD-specific functions on FD-less conns
Certain functions cannot be called on an FD-less conn because they are
normally called as part of the protocol-specific setup/teardown sequence.
Better place a few BUG_ON() to make sure none of them is called in other
situations. If any of them would trigger in ambiguous conditions, it would
always be possible to replace it with an error.
diff --git a/src/connection.c b/src/connection.c
index af453a6..b666d18 100644
--- a/src/connection.c
+++ b/src/connection.c
@@ -809,6 +809,8 @@
if (!conn_ctrl_ready(conn))
goto fail;
+ BUG_ON(conn->flags & CO_FL_FDLESS);
+
if (!fd_recv_ready(conn->handle.fd))
goto not_ready;
@@ -1188,6 +1190,8 @@
if (!conn_ctrl_ready(conn))
goto fail;
+ BUG_ON(conn->flags & CO_FL_FDLESS);
+
if (!fd_recv_ready(conn->handle.fd))
goto not_ready;
@@ -1454,6 +1458,8 @@
if (!conn_ctrl_ready(conn))
goto fail;
+ BUG_ON(conn->flags & CO_FL_FDLESS);
+
if (!fd_recv_ready(conn->handle.fd))
goto not_ready;