tree fd04fb7eef68d65e2363f47ff7c6cc1bdfca80ef
parent 4cb1637b72975c9d9e819b03d01453b860340686
author Christopher Faulet <cfaulet@haproxy.com> 1571209744 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1571214867 +0200

BUG/MINOR: http-htx: Properly set htx flags on error files to support keep-alive

When an error file was loaded, the flag HTX_SL_F_XFER_LEN was never set on the
HTX start line because of a bug. During the headers parsing, the flag
H1_MF_XFER_LEN is never set on the h1m. But it was the condition to set
HTX_SL_F_XFER_LEN on the HTX start-line. Instead, we must only rely on the flags
H1_MF_CLEN or H1_MF_CHNK.

Because of this bug, it was impossible to keep a connection alive for a response
generated by HAProxy. Now the flag HTX_SL_F_XFER_LEN is set when an error file
have a content length (chunked responses are unsupported at this stage) and the
connection may be kept alive if there is no connection header specified to
explicitly close it.

This patch must be backported to 2.0 and 1.9.

(cherry picked from commit 0d4ce93fcf9bd1f350c95f5a1bbe403bce57c680)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>