BUG/MINOR: peers: avoid an infinite loop with peers_fe is NULL
Fix an infinite loop which was added in an attempt to fix #558.
If the peers_fe is NULL, it will loop forever.
Must be backported with a2cfd7e as far as 1.8.
(cherry picked from commit 3ef2d565303af6dd7c24b62fdb22e43f1d1638bf)
Signed-off-by: Willy Tarreau <w@1wt.eu>
(cherry picked from commit 4907d7f6a13e403dea5a7bbb2e3a9923fa587807)
Signed-off-by: Willy Tarreau <w@1wt.eu>
diff --git a/src/cfgparse.c b/src/cfgparse.c
index d908765..ff086be 100644
--- a/src/cfgparse.c
+++ b/src/cfgparse.c
@@ -3948,11 +3948,10 @@
stick-table used in the configuration, set its bind_proc
by default to the first process. */
while (curpeers) {
- if (!curpeers->peers_fe)
- continue;
- if (curpeers->peers_fe->bind_proc == 0)
- curpeers->peers_fe->bind_proc = 1;
-
+ if (curpeers->peers_fe) {
+ if (curpeers->peers_fe->bind_proc == 0)
+ curpeers->peers_fe->bind_proc = 1;
+ }
curpeers = curpeers->next;
}