tree 1c02266f0d9afd84036a1612974c2a85e7462e76
parent 96d9a7f89222f41350cc847dfd205d3ad41d9cec
author William Lallemand <wlallemand@haproxy.org> 1643401050 +0100
committer Willy Tarreau <w@1wt.eu> 1645077216 +0100
encoding latin1

BUG/MINOR: mworker: fix a FD leak of a sockpair upon a failed reload

When starting HAProxy in master-worker, the master pre-allocate a struct
mworker_proc and do a socketpair() before the configuration parsing. If
the configuration loading failed, the FD are never closed because they
aren't part of listener, they are not even in the fdtab.

This patch fixes the issue by cleaning the mworker_proc structure that
were not asssigned a process, and closing its FDs.

Must be backported as far as 2.0, the srv_drop() only frees the memory
and could be dropped since it's done before an exec().

(cherry picked from commit 55a921c9147c2d45621964428c86c5ceb9fd31d8)
Signed-off-by: William Lallemand <wlallemand@haproxy.org>
(cherry picked from commit 8e75b715cb990783931d35a3fec6bf6357a688d8)
[wt: s/srv_drop()/free_server()]
Signed-off-by: Willy Tarreau <w@1wt.eu>