commit 02c92c3e6fd9daf2bb7b69c2fa83e03dbb8b800a
author Christopher Faulet <cfaulet@haproxy.com> Fri Apr 09 12:31:48 2021 +0200
committer Christopher Faulet <cfaulet@haproxy.com> Thu May 06 09:21:00 2021 +0200
tree f889e000230d5344b0c608dbd15e253151213198
parent 94d35108b48b97b578024c97ec4a4840441cbcfc

MEDIUM: mux-h1: Wake H1 stream when both sides a synchronized

Instead of subscribing for reads or sends to restart data processing, when
both sides are synchronized, the H1 stream is woken up. This happens when
H1C_F_WAIT_INPUT or H1C_F_WAIT_OUTPUT flags are removed, Indeed, these flags
block the data processing and not raw data sending or receiving.

src/mux_h1.c

diff --git a/src/mux_h1.c b/src/mux_h1.c
index 04a90e8..f6f3789 100644
--- a/src/mux_h1.c
+++ b/src/mux_h1.c
@@ -1286,16 +1286,12 @@
 
 	if (h1c->flags & H1C_F_WAIT_OUTPUT) {
 		h1c->flags &= ~H1C_F_WAIT_OUTPUT;
-		if (b_data(&h1c->ibuf))
-			h1_wake_stream_for_recv(h1s);
-		tasklet_wakeup(h1c->wait_event.tasklet);
+		h1_wake_stream_for_recv(h1s);
 		TRACE_STATE("Re-enable read on h1c", H1_EV_RX_DATA|H1_EV_H1C_BLK|H1_EV_H1C_WAKE, h1c->conn, h1s);
 	}
 	if (h1c->flags & H1C_F_WAIT_INPUT) {
 		h1c->flags &= ~H1C_F_WAIT_INPUT;
 		h1_wake_stream_for_send(h1s);
-		if (b_data(&h1c->obuf))
-			tasklet_wakeup(h1c->wait_event.tasklet);
 		TRACE_STATE("Re-enable send on h1c", H1_EV_TX_DATA|H1_EV_H1C_BLK|H1_EV_H1C_WAKE, h1c->conn, h1s);
 	}
 }
@@ -1585,7 +1581,7 @@
 				}
 				if (h1s->h1c->flags & H1C_F_WAIT_INPUT) {
 					h1s->h1c->flags &= ~H1C_F_WAIT_INPUT;
-					h1c->conn->xprt->subscribe(h1c->conn, h1c->conn->xprt_ctx, SUB_RETRY_SEND, &h1c->wait_event);
+					h1_wake_stream_for_send(h1s);
 					TRACE_STATE("Re-enable send on h1c", H1_EV_TX_DATA|H1_EV_H1C_BLK|H1_EV_H1C_WAKE, h1c->conn, h1s);
 				}
 				break;
@@ -1702,7 +1698,7 @@
 
 			if (h1s->h1c->flags & H1C_F_WAIT_INPUT) {
 				h1s->h1c->flags &= ~H1C_F_WAIT_INPUT;
-				h1c->conn->xprt->subscribe(h1c->conn, h1c->conn->xprt_ctx, SUB_RETRY_SEND, &h1c->wait_event);
+				h1_wake_stream_for_send(h1s);
 				TRACE_STATE("Re-enable send on h1c", H1_EV_TX_DATA|H1_EV_H1C_BLK|H1_EV_H1C_WAKE, h1c->conn, h1s);
 			}
 		}
@@ -1827,7 +1823,7 @@
 				h1m->state = H1_MSG_DONE;
 				if (h1s->h1c->flags & H1C_F_WAIT_OUTPUT) {
 					h1s->h1c->flags &= ~H1C_F_WAIT_OUTPUT;
-					h1c->conn->xprt->subscribe(h1c->conn, h1c->conn->xprt_ctx, SUB_RETRY_RECV, &h1c->wait_event);
+					h1_wake_stream_for_recv(h1s);
 					TRACE_STATE("Re-enable read on h1c", H1_EV_TX_DATA|H1_EV_H1C_BLK|H1_EV_H1C_WAKE, h1c->conn, h1s);
 				}
 
@@ -1875,7 +1871,7 @@
 					h1s->flags |= H1S_F_BODYLESS_RESP;
 				if (h1c->flags & H1C_F_WAIT_OUTPUT) {
 					h1c->flags &= ~H1C_F_WAIT_OUTPUT;
-					h1c->conn->xprt->subscribe(h1c->conn, h1c->conn->xprt_ctx, SUB_RETRY_RECV, &h1c->wait_event);
+					h1_wake_stream_for_recv(h1s);
 					TRACE_STATE("Re-enable read on h1c", H1_EV_TX_DATA|H1_EV_H1C_BLK|H1_EV_H1C_WAKE, h1c->conn, h1s);
 				}
 				break;
@@ -2231,7 +2227,7 @@
 
 				if (h1s->h1c->flags & H1C_F_WAIT_OUTPUT) {
 					h1s->h1c->flags &= ~H1C_F_WAIT_OUTPUT;
-					h1c->conn->xprt->subscribe(h1c->conn, h1c->conn->xprt_ctx, SUB_RETRY_RECV, &h1c->wait_event);
+					h1_wake_stream_for_recv(h1s);
 					TRACE_STATE("Re-enable read on h1c", H1_EV_TX_DATA|H1_EV_H1C_BLK|H1_EV_H1C_WAKE, h1c->conn, h1s);
 				}