tree fbc85efa996489252e74bb8fae1cb2ac08bdd59d
parent e38feed966070142e1fd5d3033c9e999a9ffe83c
author Willy Tarreau <w@1wt.eu> 1387213716 +0100
committer Willy Tarreau <w@1wt.eu> 1387213716 +0100
encoding latin1

BUG/MEDIUM: checks: servers must not start in slowstart mode

In 1.5-dev20, commit bb9665e (BUG/MEDIUM: checks: ensure we can enable
a server after boot) tried to fix a side effect of having both regular
checks and agent checks condition the up state propagation to servers.

Unfortunately it was still not fine because after this fix, servers
which make use of slowstart start in this mode. We must not check
the agent's health if agent checks are not enabled, and likewise,
we must not check the regular check's health if they are not enabled.

Reading the code, it seems like we could avoid entering this function
at all if (s->state & SRV_RUNNING) is not satisfied. Let's reserve
this for a later patch if needed.

Thanks to Sander Klein for reporting this abnormal situation.