CLEANUP: config: make the cfg_keyword parsers take a const for the defproxy
The default proxy was passed as a variable to all parsers instead of a
const, which is not without risk, especially when some timeout parsers used
to make some int pointers point to the default values for comparisons. We
want to be certain that none of these parsers will modify the defaults
sections by accident, so it's important to mark this proxy as const.
This patch touches all occurrences found (89).
diff --git a/src/vars.c b/src/vars.c
index c101c72..65930c9 100644
--- a/src/vars.c
+++ b/src/vars.c
@@ -798,7 +798,7 @@
}
static int vars_max_size(char **args, int section_type, struct proxy *curpx,
- struct proxy *defpx, const char *file, int line,
+ const struct proxy *defpx, const char *file, int line,
char **err, unsigned int *limit)
{
char *error;
@@ -812,42 +812,42 @@
}
static int vars_max_size_global(char **args, int section_type, struct proxy *curpx,
- struct proxy *defpx, const char *file, int line,
+ const struct proxy *defpx, const char *file, int line,
char **err)
{
return vars_max_size(args, section_type, curpx, defpx, file, line, err, &var_global_limit);
}
static int vars_max_size_proc(char **args, int section_type, struct proxy *curpx,
- struct proxy *defpx, const char *file, int line,
+ const struct proxy *defpx, const char *file, int line,
char **err)
{
return vars_max_size(args, section_type, curpx, defpx, file, line, err, &var_proc_limit);
}
static int vars_max_size_sess(char **args, int section_type, struct proxy *curpx,
- struct proxy *defpx, const char *file, int line,
+ const struct proxy *defpx, const char *file, int line,
char **err)
{
return vars_max_size(args, section_type, curpx, defpx, file, line, err, &var_sess_limit);
}
static int vars_max_size_txn(char **args, int section_type, struct proxy *curpx,
- struct proxy *defpx, const char *file, int line,
+ const struct proxy *defpx, const char *file, int line,
char **err)
{
return vars_max_size(args, section_type, curpx, defpx, file, line, err, &var_txn_limit);
}
static int vars_max_size_reqres(char **args, int section_type, struct proxy *curpx,
- struct proxy *defpx, const char *file, int line,
+ const struct proxy *defpx, const char *file, int line,
char **err)
{
return vars_max_size(args, section_type, curpx, defpx, file, line, err, &var_reqres_limit);
}
static int vars_max_size_check(char **args, int section_type, struct proxy *curpx,
- struct proxy *defpx, const char *file, int line,
+ const struct proxy *defpx, const char *file, int line,
char **err)
{
return vars_max_size(args, section_type, curpx, defpx, file, line, err, &var_check_limit);