MEDIUM: acl: remove unused tests for missing args when args are mandatory
A number of ACL fetch methods use mandatory arguments (eg: proxy names) so
it's pointless to test for the presence of this argument now.
diff --git a/src/frontend.c b/src/frontend.c
index 9f8c323..685b172 100644
--- a/src/frontend.c
+++ b/src/frontend.c
@@ -508,7 +508,7 @@
}
/* set temp integer to the number of connections per second reaching the frontend.
- * Accepts either 0 or 1 argument. Argument is a frontend, other types will cause
+ * Accepts exactly 1 argument. Argument is a frontend, other types will cause
* an undefined behaviour.
*/
static int
@@ -516,15 +516,12 @@
struct acl_expr *expr, struct acl_test *test)
{
test->flags = ACL_TEST_F_VOL_TEST;
- if (expr->args)
- px = expr->args->data.prx;
-
- temp_pattern.data.integer = read_freq_ctr(&px->fe_sess_per_sec);
+ temp_pattern.data.integer = read_freq_ctr(&expr->args->data.prx->fe_sess_per_sec);
return 1;
}
/* set temp integer to the number of concurrent connections on the frontend
- * Accepts either 0 or 1 argument. Argument is a frontend, other types will cause
+ * Accepts exactly 1 argument. Argument is a frontend, other types will cause
* an undefined behaviour.
*/
static int
@@ -532,10 +529,7 @@
struct acl_expr *expr, struct acl_test *test)
{
test->flags = ACL_TEST_F_VOL_TEST;
- if (expr->args)
- px = expr->args->data.prx;
-
- temp_pattern.data.integer = px->feconn;
+ temp_pattern.data.integer = expr->args->data.prx->feconn;
return 1;
}