tree d2726a300b5b0bf3a7aaa4149da5018313e807ae
parent c042249c73e62401072d2ea24eb851e6b3f4b961
author Christopher Faulet <cfaulet@haproxy.com> 1617777905 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1623918737 +0200

BUG/MINOR: stream-int: Don't block reads in si_update_rx() if chn may receive

In si_update_rx() function, the reads may be blocked because we explicitly
don't want to read or because of a lack of room in the input buffer. The
first condition is valid. However the second one only test if the channel is
empty or not. It means the reads are blocked if there are still some output
data in the input channel, in its buffer or its pipe. This condition is not
accurate. The reads must not be blocked if the channel can still receive
data. Thus instead of relying on channel_is_empty() function, we now call
channel_may_recv().

This patch is especially useful to be able to catch read0 on client side
when we are waiting for a connection to the server, when abortonclose option
is enabled. Otherwise, the client abort is not detected.

This patch depends on "MINOR: channel: Rely on HTX version if appropriate in
channel_may_recv()". Both must be backported as far as 2.0 after a period of
observation to be sure nothing broke.

(cherry picked from commit e0dec4b7b258101f6d5faa15234103a45c16f0f8)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit ae113f2d6b80262ffa1063bcf1d58e8e4b88405e)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 0522eefe9e2b5cfbf96a451f702ab3ec3ab9580c)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>