Tom Rini | 10e4779 | 2018-05-06 17:58:06 -0400 | [diff] [blame] | 1 | # SPDX-License-Identifier: GPL-2.0+ |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 2 | # Copyright (c) 2016 Google, Inc |
| 3 | # Written by Simon Glass <sjg@chromium.org> |
| 4 | # |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 5 | # Creates binary images from input files controlled by a description |
| 6 | # |
| 7 | |
| 8 | from collections import OrderedDict |
Simon Glass | 220ff5f | 2020-08-05 13:27:46 -0600 | [diff] [blame] | 9 | import glob |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 10 | import os |
Simon Glass | c1dc2f8 | 2020-08-29 11:36:14 -0600 | [diff] [blame] | 11 | import pkg_resources |
Simon Glass | a820af7 | 2020-09-06 10:39:09 -0600 | [diff] [blame] | 12 | import re |
Simon Glass | c1dc2f8 | 2020-08-29 11:36:14 -0600 | [diff] [blame] | 13 | |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 14 | import sys |
Simon Glass | a997ea5 | 2020-04-17 18:09:04 -0600 | [diff] [blame] | 15 | from patman import tools |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 16 | |
Simon Glass | 4eae925 | 2022-01-09 20:13:50 -0700 | [diff] [blame] | 17 | from binman import bintool |
Simon Glass | c585dd4 | 2020-04-17 18:09:03 -0600 | [diff] [blame] | 18 | from binman import cbfs_util |
| 19 | from binman import elf |
Simon Glass | a997ea5 | 2020-04-17 18:09:04 -0600 | [diff] [blame] | 20 | from patman import command |
| 21 | from patman import tout |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 22 | |
| 23 | # List of images we plan to create |
| 24 | # Make this global so that it can be referenced from tests |
| 25 | images = OrderedDict() |
| 26 | |
Simon Glass | a820af7 | 2020-09-06 10:39:09 -0600 | [diff] [blame] | 27 | # Help text for each type of missing blob, dict: |
| 28 | # key: Value of the entry's 'missing-msg' or entry name |
| 29 | # value: Text for the help |
| 30 | missing_blob_help = {} |
| 31 | |
Simon Glass | 55ab0b6 | 2021-03-18 20:25:06 +1300 | [diff] [blame] | 32 | def _ReadImageDesc(binman_node, use_expanded): |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 33 | """Read the image descriptions from the /binman node |
| 34 | |
| 35 | This normally produces a single Image object called 'image'. But if |
| 36 | multiple images are present, they will all be returned. |
| 37 | |
| 38 | Args: |
| 39 | binman_node: Node object of the /binman node |
Simon Glass | 55ab0b6 | 2021-03-18 20:25:06 +1300 | [diff] [blame] | 40 | use_expanded: True if the FDT will be updated with the entry information |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 41 | Returns: |
| 42 | OrderedDict of Image objects, each of which describes an image |
| 43 | """ |
| 44 | images = OrderedDict() |
| 45 | if 'multiple-images' in binman_node.props: |
| 46 | for node in binman_node.subnodes: |
Simon Glass | 55ab0b6 | 2021-03-18 20:25:06 +1300 | [diff] [blame] | 47 | images[node.name] = Image(node.name, node, |
| 48 | use_expanded=use_expanded) |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 49 | else: |
Simon Glass | 55ab0b6 | 2021-03-18 20:25:06 +1300 | [diff] [blame] | 50 | images['image'] = Image('image', binman_node, use_expanded=use_expanded) |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 51 | return images |
| 52 | |
Simon Glass | 22c92ca | 2017-05-27 07:38:29 -0600 | [diff] [blame] | 53 | def _FindBinmanNode(dtb): |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 54 | """Find the 'binman' node in the device tree |
| 55 | |
| 56 | Args: |
Simon Glass | 22c92ca | 2017-05-27 07:38:29 -0600 | [diff] [blame] | 57 | dtb: Fdt object to scan |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 58 | Returns: |
| 59 | Node object of /binman node, or None if not found |
| 60 | """ |
Simon Glass | 22c92ca | 2017-05-27 07:38:29 -0600 | [diff] [blame] | 61 | for node in dtb.GetRoot().subnodes: |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 62 | if node.name == 'binman': |
| 63 | return node |
| 64 | return None |
| 65 | |
Simon Glass | a820af7 | 2020-09-06 10:39:09 -0600 | [diff] [blame] | 66 | def _ReadMissingBlobHelp(): |
| 67 | """Read the missing-blob-help file |
| 68 | |
| 69 | This file containins help messages explaining what to do when external blobs |
| 70 | are missing. |
| 71 | |
| 72 | Returns: |
| 73 | Dict: |
| 74 | key: Message tag (str) |
| 75 | value: Message text (str) |
| 76 | """ |
| 77 | |
| 78 | def _FinishTag(tag, msg, result): |
| 79 | if tag: |
| 80 | result[tag] = msg.rstrip() |
| 81 | tag = None |
| 82 | msg = '' |
| 83 | return tag, msg |
| 84 | |
| 85 | my_data = pkg_resources.resource_string(__name__, 'missing-blob-help') |
| 86 | re_tag = re.compile('^([-a-z0-9]+):$') |
| 87 | result = {} |
| 88 | tag = None |
| 89 | msg = '' |
| 90 | for line in my_data.decode('utf-8').splitlines(): |
| 91 | if not line.startswith('#'): |
| 92 | m_tag = re_tag.match(line) |
| 93 | if m_tag: |
| 94 | _, msg = _FinishTag(tag, msg, result) |
| 95 | tag = m_tag.group(1) |
| 96 | elif tag: |
| 97 | msg += line + '\n' |
| 98 | _FinishTag(tag, msg, result) |
| 99 | return result |
| 100 | |
| 101 | def _ShowBlobHelp(path, text): |
| 102 | tout.Warning('\n%s:' % path) |
| 103 | for line in text.splitlines(): |
| 104 | tout.Warning(' %s' % line) |
| 105 | |
| 106 | def _ShowHelpForMissingBlobs(missing_list): |
| 107 | """Show help for each missing blob to help the user take action |
| 108 | |
| 109 | Args: |
| 110 | missing_list: List of Entry objects to show help for |
| 111 | """ |
| 112 | global missing_blob_help |
| 113 | |
| 114 | if not missing_blob_help: |
| 115 | missing_blob_help = _ReadMissingBlobHelp() |
| 116 | |
| 117 | for entry in missing_list: |
| 118 | tags = entry.GetHelpTags() |
| 119 | |
| 120 | # Show the first match help message |
| 121 | for tag in tags: |
| 122 | if tag in missing_blob_help: |
| 123 | _ShowBlobHelp(entry._node.path, missing_blob_help[tag]) |
| 124 | break |
| 125 | |
Simon Glass | 220ff5f | 2020-08-05 13:27:46 -0600 | [diff] [blame] | 126 | def GetEntryModules(include_testing=True): |
| 127 | """Get a set of entry class implementations |
| 128 | |
| 129 | Returns: |
| 130 | Set of paths to entry class filenames |
| 131 | """ |
Simon Glass | c1dc2f8 | 2020-08-29 11:36:14 -0600 | [diff] [blame] | 132 | glob_list = pkg_resources.resource_listdir(__name__, 'etype') |
| 133 | glob_list = [fname for fname in glob_list if fname.endswith('.py')] |
Simon Glass | 220ff5f | 2020-08-05 13:27:46 -0600 | [diff] [blame] | 134 | return set([os.path.splitext(os.path.basename(item))[0] |
| 135 | for item in glob_list |
| 136 | if include_testing or '_testing' not in item]) |
| 137 | |
Simon Glass | 29aa736 | 2018-09-14 04:57:19 -0600 | [diff] [blame] | 138 | def WriteEntryDocs(modules, test_missing=None): |
| 139 | """Write out documentation for all entries |
Simon Glass | 9230773 | 2018-07-06 10:27:40 -0600 | [diff] [blame] | 140 | |
| 141 | Args: |
Simon Glass | 29aa736 | 2018-09-14 04:57:19 -0600 | [diff] [blame] | 142 | modules: List of Module objects to get docs for |
| 143 | test_missing: Used for testing only, to force an entry's documeentation |
| 144 | to show as missing even if it is present. Should be set to None in |
| 145 | normal use. |
Simon Glass | 9230773 | 2018-07-06 10:27:40 -0600 | [diff] [blame] | 146 | """ |
Simon Glass | c585dd4 | 2020-04-17 18:09:03 -0600 | [diff] [blame] | 147 | from binman.entry import Entry |
Simon Glass | 969616c | 2018-07-17 13:25:36 -0600 | [diff] [blame] | 148 | Entry.WriteDocs(modules, test_missing) |
| 149 | |
Simon Glass | b2fd11d | 2019-07-08 14:25:48 -0600 | [diff] [blame] | 150 | |
| 151 | def ListEntries(image_fname, entry_paths): |
| 152 | """List the entries in an image |
| 153 | |
| 154 | This decodes the supplied image and displays a table of entries from that |
| 155 | image, preceded by a header. |
| 156 | |
| 157 | Args: |
| 158 | image_fname: Image filename to process |
| 159 | entry_paths: List of wildcarded paths (e.g. ['*dtb*', 'u-boot*', |
| 160 | 'section/u-boot']) |
| 161 | """ |
| 162 | image = Image.FromFile(image_fname) |
| 163 | |
| 164 | entries, lines, widths = image.GetListEntries(entry_paths) |
| 165 | |
| 166 | num_columns = len(widths) |
| 167 | for linenum, line in enumerate(lines): |
| 168 | if linenum == 1: |
| 169 | # Print header line |
| 170 | print('-' * (sum(widths) + num_columns * 2)) |
| 171 | out = '' |
| 172 | for i, item in enumerate(line): |
| 173 | width = -widths[i] |
| 174 | if item.startswith('>'): |
| 175 | width = -width |
| 176 | item = item[1:] |
| 177 | txt = '%*s ' % (width, item) |
| 178 | out += txt |
| 179 | print(out.rstrip()) |
| 180 | |
Simon Glass | 4c613bf | 2019-07-08 14:25:50 -0600 | [diff] [blame] | 181 | |
| 182 | def ReadEntry(image_fname, entry_path, decomp=True): |
| 183 | """Extract an entry from an image |
| 184 | |
| 185 | This extracts the data from a particular entry in an image |
| 186 | |
| 187 | Args: |
| 188 | image_fname: Image filename to process |
| 189 | entry_path: Path to entry to extract |
| 190 | decomp: True to return uncompressed data, if the data is compress |
| 191 | False to return the raw data |
| 192 | |
| 193 | Returns: |
| 194 | data extracted from the entry |
| 195 | """ |
Simon Glass | b9ba4e0 | 2019-08-24 07:22:44 -0600 | [diff] [blame] | 196 | global Image |
Simon Glass | 90cd6f0 | 2020-08-05 13:27:47 -0600 | [diff] [blame] | 197 | from binman.image import Image |
Simon Glass | b9ba4e0 | 2019-08-24 07:22:44 -0600 | [diff] [blame] | 198 | |
Simon Glass | 4c613bf | 2019-07-08 14:25:50 -0600 | [diff] [blame] | 199 | image = Image.FromFile(image_fname) |
| 200 | entry = image.FindEntryPath(entry_path) |
| 201 | return entry.ReadData(decomp) |
| 202 | |
| 203 | |
Simon Glass | 637958f | 2021-11-23 21:09:50 -0700 | [diff] [blame] | 204 | def ShowAltFormats(image): |
| 205 | """Show alternative formats available for entries in the image |
| 206 | |
| 207 | This shows a list of formats available. |
| 208 | |
| 209 | Args: |
| 210 | image (Image): Image to check |
| 211 | """ |
| 212 | alt_formats = {} |
| 213 | image.CheckAltFormats(alt_formats) |
| 214 | print('%-10s %-20s %s' % ('Flag (-F)', 'Entry type', 'Description')) |
| 215 | for name, val in alt_formats.items(): |
| 216 | entry, helptext = val |
| 217 | print('%-10s %-20s %s' % (name, entry.etype, helptext)) |
| 218 | |
| 219 | |
Simon Glass | 980a284 | 2019-07-08 14:25:52 -0600 | [diff] [blame] | 220 | def ExtractEntries(image_fname, output_fname, outdir, entry_paths, |
Simon Glass | 637958f | 2021-11-23 21:09:50 -0700 | [diff] [blame] | 221 | decomp=True, alt_format=None): |
Simon Glass | 980a284 | 2019-07-08 14:25:52 -0600 | [diff] [blame] | 222 | """Extract the data from one or more entries and write it to files |
| 223 | |
| 224 | Args: |
| 225 | image_fname: Image filename to process |
| 226 | output_fname: Single output filename to use if extracting one file, None |
| 227 | otherwise |
| 228 | outdir: Output directory to use (for any number of files), else None |
| 229 | entry_paths: List of entry paths to extract |
Simon Glass | d48f94e | 2019-07-20 12:24:12 -0600 | [diff] [blame] | 230 | decomp: True to decompress the entry data |
Simon Glass | 980a284 | 2019-07-08 14:25:52 -0600 | [diff] [blame] | 231 | |
| 232 | Returns: |
| 233 | List of EntryInfo records that were written |
| 234 | """ |
| 235 | image = Image.FromFile(image_fname) |
| 236 | |
Simon Glass | 637958f | 2021-11-23 21:09:50 -0700 | [diff] [blame] | 237 | if alt_format == 'list': |
| 238 | ShowAltFormats(image) |
| 239 | return |
| 240 | |
Simon Glass | 980a284 | 2019-07-08 14:25:52 -0600 | [diff] [blame] | 241 | # Output an entry to a single file, as a special case |
| 242 | if output_fname: |
| 243 | if not entry_paths: |
Simon Glass | a772d3f | 2019-07-20 12:24:14 -0600 | [diff] [blame] | 244 | raise ValueError('Must specify an entry path to write with -f') |
Simon Glass | 980a284 | 2019-07-08 14:25:52 -0600 | [diff] [blame] | 245 | if len(entry_paths) != 1: |
Simon Glass | a772d3f | 2019-07-20 12:24:14 -0600 | [diff] [blame] | 246 | raise ValueError('Must specify exactly one entry path to write with -f') |
Simon Glass | 980a284 | 2019-07-08 14:25:52 -0600 | [diff] [blame] | 247 | entry = image.FindEntryPath(entry_paths[0]) |
Simon Glass | 637958f | 2021-11-23 21:09:50 -0700 | [diff] [blame] | 248 | data = entry.ReadData(decomp, alt_format) |
Simon Glass | 980a284 | 2019-07-08 14:25:52 -0600 | [diff] [blame] | 249 | tools.WriteFile(output_fname, data) |
| 250 | tout.Notice("Wrote %#x bytes to file '%s'" % (len(data), output_fname)) |
| 251 | return |
| 252 | |
| 253 | # Otherwise we will output to a path given by the entry path of each entry. |
| 254 | # This means that entries will appear in subdirectories if they are part of |
| 255 | # a sub-section. |
| 256 | einfos = image.GetListEntries(entry_paths)[0] |
| 257 | tout.Notice('%d entries match and will be written' % len(einfos)) |
| 258 | for einfo in einfos: |
| 259 | entry = einfo.entry |
Simon Glass | 637958f | 2021-11-23 21:09:50 -0700 | [diff] [blame] | 260 | data = entry.ReadData(decomp, alt_format) |
Simon Glass | 980a284 | 2019-07-08 14:25:52 -0600 | [diff] [blame] | 261 | path = entry.GetPath()[1:] |
| 262 | fname = os.path.join(outdir, path) |
| 263 | |
| 264 | # If this entry has children, create a directory for it and put its |
| 265 | # data in a file called 'root' in that directory |
| 266 | if entry.GetEntries(): |
Simon Glass | 4ef93d9 | 2021-03-18 20:24:51 +1300 | [diff] [blame] | 267 | if fname and not os.path.exists(fname): |
Simon Glass | 980a284 | 2019-07-08 14:25:52 -0600 | [diff] [blame] | 268 | os.makedirs(fname) |
| 269 | fname = os.path.join(fname, 'root') |
Simon Glass | 0834945 | 2021-01-06 21:35:13 -0700 | [diff] [blame] | 270 | tout.Notice("Write entry '%s' size %x to '%s'" % |
| 271 | (entry.GetPath(), len(data), fname)) |
Simon Glass | 980a284 | 2019-07-08 14:25:52 -0600 | [diff] [blame] | 272 | tools.WriteFile(fname, data) |
| 273 | return einfos |
| 274 | |
| 275 | |
Simon Glass | 274bd0e | 2019-07-20 12:24:13 -0600 | [diff] [blame] | 276 | def BeforeReplace(image, allow_resize): |
| 277 | """Handle getting an image ready for replacing entries in it |
| 278 | |
| 279 | Args: |
| 280 | image: Image to prepare |
| 281 | """ |
| 282 | state.PrepareFromLoadedData(image) |
| 283 | image.LoadData() |
| 284 | |
| 285 | # If repacking, drop the old offset/size values except for the original |
| 286 | # ones, so we are only left with the constraints. |
| 287 | if allow_resize: |
| 288 | image.ResetForPack() |
| 289 | |
| 290 | |
| 291 | def ReplaceOneEntry(image, entry, data, do_compress, allow_resize): |
| 292 | """Handle replacing a single entry an an image |
| 293 | |
| 294 | Args: |
| 295 | image: Image to update |
| 296 | entry: Entry to write |
| 297 | data: Data to replace with |
| 298 | do_compress: True to compress the data if needed, False if data is |
| 299 | already compressed so should be used as is |
| 300 | allow_resize: True to allow entries to change size (this does a re-pack |
| 301 | of the entries), False to raise an exception |
| 302 | """ |
| 303 | if not entry.WriteData(data, do_compress): |
| 304 | if not image.allow_repack: |
| 305 | entry.Raise('Entry data size does not match, but allow-repack is not present for this image') |
| 306 | if not allow_resize: |
| 307 | entry.Raise('Entry data size does not match, but resize is disabled') |
| 308 | |
| 309 | |
| 310 | def AfterReplace(image, allow_resize, write_map): |
| 311 | """Handle write out an image after replacing entries in it |
| 312 | |
| 313 | Args: |
| 314 | image: Image to write |
| 315 | allow_resize: True to allow entries to change size (this does a re-pack |
| 316 | of the entries), False to raise an exception |
| 317 | write_map: True to write a map file |
| 318 | """ |
| 319 | tout.Info('Processing image') |
| 320 | ProcessImage(image, update_fdt=True, write_map=write_map, |
| 321 | get_contents=False, allow_resize=allow_resize) |
| 322 | |
| 323 | |
| 324 | def WriteEntryToImage(image, entry, data, do_compress=True, allow_resize=True, |
| 325 | write_map=False): |
| 326 | BeforeReplace(image, allow_resize) |
| 327 | tout.Info('Writing data to %s' % entry.GetPath()) |
| 328 | ReplaceOneEntry(image, entry, data, do_compress, allow_resize) |
| 329 | AfterReplace(image, allow_resize=allow_resize, write_map=write_map) |
| 330 | |
| 331 | |
Simon Glass | d48f94e | 2019-07-20 12:24:12 -0600 | [diff] [blame] | 332 | def WriteEntry(image_fname, entry_path, data, do_compress=True, |
| 333 | allow_resize=True, write_map=False): |
Simon Glass | 3971c95 | 2019-07-20 12:24:11 -0600 | [diff] [blame] | 334 | """Replace an entry in an image |
| 335 | |
| 336 | This replaces the data in a particular entry in an image. This size of the |
| 337 | new data must match the size of the old data unless allow_resize is True. |
| 338 | |
| 339 | Args: |
| 340 | image_fname: Image filename to process |
| 341 | entry_path: Path to entry to extract |
| 342 | data: Data to replace with |
Simon Glass | d48f94e | 2019-07-20 12:24:12 -0600 | [diff] [blame] | 343 | do_compress: True to compress the data if needed, False if data is |
Simon Glass | 3971c95 | 2019-07-20 12:24:11 -0600 | [diff] [blame] | 344 | already compressed so should be used as is |
| 345 | allow_resize: True to allow entries to change size (this does a re-pack |
| 346 | of the entries), False to raise an exception |
Simon Glass | d48f94e | 2019-07-20 12:24:12 -0600 | [diff] [blame] | 347 | write_map: True to write a map file |
Simon Glass | 3971c95 | 2019-07-20 12:24:11 -0600 | [diff] [blame] | 348 | |
| 349 | Returns: |
| 350 | Image object that was updated |
| 351 | """ |
Simon Glass | 274bd0e | 2019-07-20 12:24:13 -0600 | [diff] [blame] | 352 | tout.Info("Write entry '%s', file '%s'" % (entry_path, image_fname)) |
Simon Glass | 3971c95 | 2019-07-20 12:24:11 -0600 | [diff] [blame] | 353 | image = Image.FromFile(image_fname) |
| 354 | entry = image.FindEntryPath(entry_path) |
Simon Glass | 274bd0e | 2019-07-20 12:24:13 -0600 | [diff] [blame] | 355 | WriteEntryToImage(image, entry, data, do_compress=do_compress, |
| 356 | allow_resize=allow_resize, write_map=write_map) |
Simon Glass | 3971c95 | 2019-07-20 12:24:11 -0600 | [diff] [blame] | 357 | |
Simon Glass | 3971c95 | 2019-07-20 12:24:11 -0600 | [diff] [blame] | 358 | return image |
| 359 | |
Simon Glass | 30033c2 | 2019-07-20 12:24:15 -0600 | [diff] [blame] | 360 | |
| 361 | def ReplaceEntries(image_fname, input_fname, indir, entry_paths, |
| 362 | do_compress=True, allow_resize=True, write_map=False): |
| 363 | """Replace the data from one or more entries from input files |
| 364 | |
| 365 | Args: |
| 366 | image_fname: Image filename to process |
Jan Kiszka | 8ea4443 | 2021-11-11 08:13:30 +0100 | [diff] [blame] | 367 | input_fname: Single input filename to use if replacing one file, None |
Simon Glass | 30033c2 | 2019-07-20 12:24:15 -0600 | [diff] [blame] | 368 | otherwise |
| 369 | indir: Input directory to use (for any number of files), else None |
Jan Kiszka | 8ea4443 | 2021-11-11 08:13:30 +0100 | [diff] [blame] | 370 | entry_paths: List of entry paths to replace |
Simon Glass | 30033c2 | 2019-07-20 12:24:15 -0600 | [diff] [blame] | 371 | do_compress: True if the input data is uncompressed and may need to be |
| 372 | compressed if the entry requires it, False if the data is already |
| 373 | compressed. |
| 374 | write_map: True to write a map file |
| 375 | |
| 376 | Returns: |
| 377 | List of EntryInfo records that were written |
| 378 | """ |
Jan Kiszka | afc8f29 | 2021-11-11 08:14:18 +0100 | [diff] [blame] | 379 | image_fname = os.path.abspath(image_fname) |
Simon Glass | 30033c2 | 2019-07-20 12:24:15 -0600 | [diff] [blame] | 380 | image = Image.FromFile(image_fname) |
| 381 | |
| 382 | # Replace an entry from a single file, as a special case |
| 383 | if input_fname: |
| 384 | if not entry_paths: |
| 385 | raise ValueError('Must specify an entry path to read with -f') |
| 386 | if len(entry_paths) != 1: |
| 387 | raise ValueError('Must specify exactly one entry path to write with -f') |
| 388 | entry = image.FindEntryPath(entry_paths[0]) |
| 389 | data = tools.ReadFile(input_fname) |
| 390 | tout.Notice("Read %#x bytes from file '%s'" % (len(data), input_fname)) |
| 391 | WriteEntryToImage(image, entry, data, do_compress=do_compress, |
| 392 | allow_resize=allow_resize, write_map=write_map) |
| 393 | return |
| 394 | |
| 395 | # Otherwise we will input from a path given by the entry path of each entry. |
| 396 | # This means that files must appear in subdirectories if they are part of |
| 397 | # a sub-section. |
| 398 | einfos = image.GetListEntries(entry_paths)[0] |
| 399 | tout.Notice("Replacing %d matching entries in image '%s'" % |
| 400 | (len(einfos), image_fname)) |
| 401 | |
| 402 | BeforeReplace(image, allow_resize) |
| 403 | |
| 404 | for einfo in einfos: |
| 405 | entry = einfo.entry |
| 406 | if entry.GetEntries(): |
| 407 | tout.Info("Skipping section entry '%s'" % entry.GetPath()) |
| 408 | continue |
| 409 | |
| 410 | path = entry.GetPath()[1:] |
| 411 | fname = os.path.join(indir, path) |
| 412 | |
| 413 | if os.path.exists(fname): |
| 414 | tout.Notice("Write entry '%s' from file '%s'" % |
| 415 | (entry.GetPath(), fname)) |
| 416 | data = tools.ReadFile(fname) |
| 417 | ReplaceOneEntry(image, entry, data, do_compress, allow_resize) |
| 418 | else: |
| 419 | tout.Warning("Skipping entry '%s' from missing file '%s'" % |
| 420 | (entry.GetPath(), fname)) |
| 421 | |
| 422 | AfterReplace(image, allow_resize=allow_resize, write_map=write_map) |
| 423 | return image |
| 424 | |
| 425 | |
Simon Glass | 55ab0b6 | 2021-03-18 20:25:06 +1300 | [diff] [blame] | 426 | def PrepareImagesAndDtbs(dtb_fname, select_images, update_fdt, use_expanded): |
Simon Glass | d3151ff | 2019-07-20 12:23:27 -0600 | [diff] [blame] | 427 | """Prepare the images to be processed and select the device tree |
| 428 | |
| 429 | This function: |
| 430 | - reads in the device tree |
| 431 | - finds and scans the binman node to create all entries |
| 432 | - selects which images to build |
| 433 | - Updates the device tress with placeholder properties for offset, |
| 434 | image-pos, etc. |
| 435 | |
| 436 | Args: |
| 437 | dtb_fname: Filename of the device tree file to use (.dts or .dtb) |
| 438 | selected_images: List of images to output, or None for all |
| 439 | update_fdt: True to update the FDT wth entry offsets, etc. |
Simon Glass | 55ab0b6 | 2021-03-18 20:25:06 +1300 | [diff] [blame] | 440 | use_expanded: True to use expanded versions of entries, if available. |
| 441 | So if 'u-boot' is called for, we use 'u-boot-expanded' instead. This |
| 442 | is needed if update_fdt is True (although tests may disable it) |
Simon Glass | 31ee50f | 2020-09-01 05:13:55 -0600 | [diff] [blame] | 443 | |
| 444 | Returns: |
| 445 | OrderedDict of images: |
| 446 | key: Image name (str) |
| 447 | value: Image object |
Simon Glass | d3151ff | 2019-07-20 12:23:27 -0600 | [diff] [blame] | 448 | """ |
| 449 | # Import these here in case libfdt.py is not available, in which case |
| 450 | # the above help option still works. |
Simon Glass | c585dd4 | 2020-04-17 18:09:03 -0600 | [diff] [blame] | 451 | from dtoc import fdt |
| 452 | from dtoc import fdt_util |
Simon Glass | d3151ff | 2019-07-20 12:23:27 -0600 | [diff] [blame] | 453 | global images |
| 454 | |
| 455 | # Get the device tree ready by compiling it and copying the compiled |
| 456 | # output into a file in our output directly. Then scan it for use |
| 457 | # in binman. |
| 458 | dtb_fname = fdt_util.EnsureCompiled(dtb_fname) |
| 459 | fname = tools.GetOutputFilename('u-boot.dtb.out') |
| 460 | tools.WriteFile(fname, tools.ReadFile(dtb_fname)) |
| 461 | dtb = fdt.FdtScan(fname) |
| 462 | |
| 463 | node = _FindBinmanNode(dtb) |
| 464 | if not node: |
| 465 | raise ValueError("Device tree '%s' does not have a 'binman' " |
| 466 | "node" % dtb_fname) |
| 467 | |
Simon Glass | 55ab0b6 | 2021-03-18 20:25:06 +1300 | [diff] [blame] | 468 | images = _ReadImageDesc(node, use_expanded) |
Simon Glass | d3151ff | 2019-07-20 12:23:27 -0600 | [diff] [blame] | 469 | |
| 470 | if select_images: |
| 471 | skip = [] |
| 472 | new_images = OrderedDict() |
| 473 | for name, image in images.items(): |
| 474 | if name in select_images: |
| 475 | new_images[name] = image |
| 476 | else: |
| 477 | skip.append(name) |
| 478 | images = new_images |
| 479 | tout.Notice('Skipping images: %s' % ', '.join(skip)) |
| 480 | |
| 481 | state.Prepare(images, dtb) |
| 482 | |
| 483 | # Prepare the device tree by making sure that any missing |
| 484 | # properties are added (e.g. 'pos' and 'size'). The values of these |
| 485 | # may not be correct yet, but we add placeholders so that the |
| 486 | # size of the device tree is correct. Later, in |
| 487 | # SetCalculatedProperties() we will insert the correct values |
| 488 | # without changing the device-tree size, thus ensuring that our |
| 489 | # entry offsets remain the same. |
| 490 | for image in images.values(): |
Simon Glass | 4eae925 | 2022-01-09 20:13:50 -0700 | [diff] [blame] | 491 | image.CollectBintools() |
Simon Glass | d3151ff | 2019-07-20 12:23:27 -0600 | [diff] [blame] | 492 | image.ExpandEntries() |
| 493 | if update_fdt: |
Simon Glass | acd6c6e | 2020-10-26 17:40:17 -0600 | [diff] [blame] | 494 | image.AddMissingProperties(True) |
Simon Glass | d3151ff | 2019-07-20 12:23:27 -0600 | [diff] [blame] | 495 | image.ProcessFdt(dtb) |
| 496 | |
Simon Glass | 5a30060 | 2019-07-20 12:23:29 -0600 | [diff] [blame] | 497 | for dtb_item in state.GetAllFdts(): |
Simon Glass | d3151ff | 2019-07-20 12:23:27 -0600 | [diff] [blame] | 498 | dtb_item.Sync(auto_resize=True) |
| 499 | dtb_item.Pack() |
| 500 | dtb_item.Flush() |
| 501 | return images |
| 502 | |
| 503 | |
Simon Glass | f8a54bc | 2019-07-20 12:23:56 -0600 | [diff] [blame] | 504 | def ProcessImage(image, update_fdt, write_map, get_contents=True, |
Heiko Thiery | 6d45136 | 2022-01-06 11:49:41 +0100 | [diff] [blame] | 505 | allow_resize=True, allow_missing=False, |
| 506 | allow_fake_blobs=False): |
Simon Glass | b766c5e5 | 2019-07-20 12:23:24 -0600 | [diff] [blame] | 507 | """Perform all steps for this image, including checking and # writing it. |
| 508 | |
| 509 | This means that errors found with a later image will be reported after |
| 510 | earlier images are already completed and written, but that does not seem |
| 511 | important. |
| 512 | |
| 513 | Args: |
| 514 | image: Image to process |
| 515 | update_fdt: True to update the FDT wth entry offsets, etc. |
| 516 | write_map: True to write a map file |
Simon Glass | 072959a | 2019-07-20 12:23:50 -0600 | [diff] [blame] | 517 | get_contents: True to get the image contents from files, etc., False if |
| 518 | the contents is already present |
Simon Glass | f8a54bc | 2019-07-20 12:23:56 -0600 | [diff] [blame] | 519 | allow_resize: True to allow entries to change size (this does a re-pack |
| 520 | of the entries), False to raise an exception |
Simon Glass | 5d94cc6 | 2020-07-09 18:39:38 -0600 | [diff] [blame] | 521 | allow_missing: Allow blob_ext objects to be missing |
Heiko Thiery | 6d45136 | 2022-01-06 11:49:41 +0100 | [diff] [blame] | 522 | allow_fake_blobs: Allow blob_ext objects to be faked with dummy files |
Simon Glass | a003cd3 | 2020-07-09 18:39:40 -0600 | [diff] [blame] | 523 | |
| 524 | Returns: |
Heiko Thiery | 6d45136 | 2022-01-06 11:49:41 +0100 | [diff] [blame] | 525 | True if one or more external blobs are missing or faked, |
| 526 | False if all are present |
Simon Glass | b766c5e5 | 2019-07-20 12:23:24 -0600 | [diff] [blame] | 527 | """ |
Simon Glass | 072959a | 2019-07-20 12:23:50 -0600 | [diff] [blame] | 528 | if get_contents: |
Simon Glass | 5d94cc6 | 2020-07-09 18:39:38 -0600 | [diff] [blame] | 529 | image.SetAllowMissing(allow_missing) |
Heiko Thiery | 6d45136 | 2022-01-06 11:49:41 +0100 | [diff] [blame] | 530 | image.SetAllowFakeBlob(allow_fake_blobs) |
Simon Glass | 072959a | 2019-07-20 12:23:50 -0600 | [diff] [blame] | 531 | image.GetEntryContents() |
Simon Glass | b766c5e5 | 2019-07-20 12:23:24 -0600 | [diff] [blame] | 532 | image.GetEntryOffsets() |
| 533 | |
| 534 | # We need to pack the entries to figure out where everything |
| 535 | # should be placed. This sets the offset/size of each entry. |
| 536 | # However, after packing we call ProcessEntryContents() which |
| 537 | # may result in an entry changing size. In that case we need to |
| 538 | # do another pass. Since the device tree often contains the |
| 539 | # final offset/size information we try to make space for this in |
| 540 | # AddMissingProperties() above. However, if the device is |
| 541 | # compressed we cannot know this compressed size in advance, |
| 542 | # since changing an offset from 0x100 to 0x104 (for example) can |
| 543 | # alter the compressed size of the device tree. So we need a |
| 544 | # third pass for this. |
Simon Glass | 37fdd14 | 2019-07-20 12:24:06 -0600 | [diff] [blame] | 545 | passes = 5 |
Simon Glass | b766c5e5 | 2019-07-20 12:23:24 -0600 | [diff] [blame] | 546 | for pack_pass in range(passes): |
| 547 | try: |
| 548 | image.PackEntries() |
Simon Glass | b766c5e5 | 2019-07-20 12:23:24 -0600 | [diff] [blame] | 549 | except Exception as e: |
| 550 | if write_map: |
| 551 | fname = image.WriteMap() |
| 552 | print("Wrote map file '%s' to show errors" % fname) |
| 553 | raise |
| 554 | image.SetImagePos() |
| 555 | if update_fdt: |
| 556 | image.SetCalculatedProperties() |
Simon Glass | 5a30060 | 2019-07-20 12:23:29 -0600 | [diff] [blame] | 557 | for dtb_item in state.GetAllFdts(): |
Simon Glass | b766c5e5 | 2019-07-20 12:23:24 -0600 | [diff] [blame] | 558 | dtb_item.Sync() |
Simon Glass | f8a54bc | 2019-07-20 12:23:56 -0600 | [diff] [blame] | 559 | dtb_item.Flush() |
Simon Glass | e594341 | 2019-08-24 07:23:12 -0600 | [diff] [blame] | 560 | image.WriteSymbols() |
Simon Glass | b766c5e5 | 2019-07-20 12:23:24 -0600 | [diff] [blame] | 561 | sizes_ok = image.ProcessEntryContents() |
| 562 | if sizes_ok: |
| 563 | break |
| 564 | image.ResetForPack() |
Simon Glass | 6bf9b47 | 2019-08-24 07:23:13 -0600 | [diff] [blame] | 565 | tout.Info('Pack completed after %d pass(es)' % (pack_pass + 1)) |
Simon Glass | b766c5e5 | 2019-07-20 12:23:24 -0600 | [diff] [blame] | 566 | if not sizes_ok: |
Simon Glass | 9d8ee32 | 2019-07-20 12:23:58 -0600 | [diff] [blame] | 567 | image.Raise('Entries changed size after packing (tried %s passes)' % |
Simon Glass | b766c5e5 | 2019-07-20 12:23:24 -0600 | [diff] [blame] | 568 | passes) |
| 569 | |
Simon Glass | b766c5e5 | 2019-07-20 12:23:24 -0600 | [diff] [blame] | 570 | image.BuildImage() |
| 571 | if write_map: |
| 572 | image.WriteMap() |
Simon Glass | a003cd3 | 2020-07-09 18:39:40 -0600 | [diff] [blame] | 573 | missing_list = [] |
| 574 | image.CheckMissing(missing_list) |
| 575 | if missing_list: |
| 576 | tout.Warning("Image '%s' is missing external blobs and is non-functional: %s" % |
| 577 | (image.name, ' '.join([e.name for e in missing_list]))) |
Simon Glass | a820af7 | 2020-09-06 10:39:09 -0600 | [diff] [blame] | 578 | _ShowHelpForMissingBlobs(missing_list) |
Heiko Thiery | 6d45136 | 2022-01-06 11:49:41 +0100 | [diff] [blame] | 579 | faked_list = [] |
| 580 | image.CheckFakedBlobs(faked_list) |
| 581 | if faked_list: |
Simon Glass | 7a602fd | 2022-01-12 13:10:36 -0700 | [diff] [blame] | 582 | tout.Warning( |
Simon Glass | f9f3403 | 2022-01-09 20:13:45 -0700 | [diff] [blame] | 583 | "Image '%s' has faked external blobs and is non-functional: %s" % |
| 584 | (image.name, ' '.join([os.path.basename(e.GetDefaultFilename()) |
| 585 | for e in faked_list]))) |
Heiko Thiery | 6d45136 | 2022-01-06 11:49:41 +0100 | [diff] [blame] | 586 | return bool(missing_list) or bool(faked_list) |
Simon Glass | b766c5e5 | 2019-07-20 12:23:24 -0600 | [diff] [blame] | 587 | |
| 588 | |
Simon Glass | f46732a | 2019-07-08 14:25:29 -0600 | [diff] [blame] | 589 | def Binman(args): |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 590 | """The main control code for binman |
| 591 | |
| 592 | This assumes that help and test options have already been dealt with. It |
| 593 | deals with the core task of building images. |
| 594 | |
| 595 | Args: |
Simon Glass | f46732a | 2019-07-08 14:25:29 -0600 | [diff] [blame] | 596 | args: Command line arguments Namespace object |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 597 | """ |
Simon Glass | b9ba4e0 | 2019-08-24 07:22:44 -0600 | [diff] [blame] | 598 | global Image |
| 599 | global state |
| 600 | |
Simon Glass | f46732a | 2019-07-08 14:25:29 -0600 | [diff] [blame] | 601 | if args.full_help: |
Paul Barker | 25ecd97 | 2021-09-08 12:38:01 +0100 | [diff] [blame] | 602 | tools.PrintFullHelp( |
| 603 | os.path.join(os.path.dirname(os.path.realpath(sys.argv[0])), 'README.rst') |
| 604 | ) |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 605 | return 0 |
| 606 | |
Simon Glass | b9ba4e0 | 2019-08-24 07:22:44 -0600 | [diff] [blame] | 607 | # Put these here so that we can import this module without libfdt |
Simon Glass | 90cd6f0 | 2020-08-05 13:27:47 -0600 | [diff] [blame] | 608 | from binman.image import Image |
Simon Glass | c585dd4 | 2020-04-17 18:09:03 -0600 | [diff] [blame] | 609 | from binman import state |
Simon Glass | b9ba4e0 | 2019-08-24 07:22:44 -0600 | [diff] [blame] | 610 | |
Simon Glass | 4eae925 | 2022-01-09 20:13:50 -0700 | [diff] [blame] | 611 | if args.cmd in ['ls', 'extract', 'replace', 'tool']: |
Simon Glass | 9b7f500 | 2019-07-20 12:23:53 -0600 | [diff] [blame] | 612 | try: |
Simon Glass | df08cbb | 2019-09-15 18:10:36 -0600 | [diff] [blame] | 613 | tout.Init(args.verbosity) |
Simon Glass | 9b7f500 | 2019-07-20 12:23:53 -0600 | [diff] [blame] | 614 | tools.PrepareOutputDir(None) |
Simon Glass | df08cbb | 2019-09-15 18:10:36 -0600 | [diff] [blame] | 615 | if args.cmd == 'ls': |
| 616 | ListEntries(args.image, args.paths) |
Simon Glass | b2fd11d | 2019-07-08 14:25:48 -0600 | [diff] [blame] | 617 | |
Simon Glass | df08cbb | 2019-09-15 18:10:36 -0600 | [diff] [blame] | 618 | if args.cmd == 'extract': |
| 619 | ExtractEntries(args.image, args.filename, args.outdir, args.paths, |
Simon Glass | 637958f | 2021-11-23 21:09:50 -0700 | [diff] [blame] | 620 | not args.uncompressed, args.format) |
Simon Glass | 980a284 | 2019-07-08 14:25:52 -0600 | [diff] [blame] | 621 | |
Simon Glass | df08cbb | 2019-09-15 18:10:36 -0600 | [diff] [blame] | 622 | if args.cmd == 'replace': |
| 623 | ReplaceEntries(args.image, args.filename, args.indir, args.paths, |
| 624 | do_compress=not args.compressed, |
| 625 | allow_resize=not args.fix_size, write_map=args.map) |
Simon Glass | 4eae925 | 2022-01-09 20:13:50 -0700 | [diff] [blame] | 626 | |
| 627 | if args.cmd == 'tool': |
| 628 | tools.SetToolPaths(args.toolpath) |
| 629 | if args.list: |
| 630 | bintool.Bintool.list_all() |
| 631 | elif args.fetch: |
| 632 | if not args.bintools: |
| 633 | raise ValueError( |
| 634 | "Please specify bintools to fetch or 'all' or 'missing'") |
| 635 | bintool.Bintool.fetch_tools(bintool.FETCH_ANY, |
| 636 | args.bintools) |
| 637 | else: |
| 638 | raise ValueError("Invalid arguments to 'tool' subcommand") |
Simon Glass | df08cbb | 2019-09-15 18:10:36 -0600 | [diff] [blame] | 639 | except: |
| 640 | raise |
Simon Glass | 30033c2 | 2019-07-20 12:24:15 -0600 | [diff] [blame] | 641 | finally: |
| 642 | tools.FinaliseOutputDir() |
| 643 | return 0 |
| 644 | |
Simon Glass | adfb849 | 2021-11-03 21:09:18 -0600 | [diff] [blame] | 645 | elf_params = None |
| 646 | if args.update_fdt_in_elf: |
| 647 | elf_params = args.update_fdt_in_elf.split(',') |
| 648 | if len(elf_params) != 4: |
| 649 | raise ValueError('Invalid args %s to --update-fdt-in-elf: expected infile,outfile,begin_sym,end_sym' % |
| 650 | elf_params) |
| 651 | |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 652 | # Try to figure out which device tree contains our image description |
Simon Glass | f46732a | 2019-07-08 14:25:29 -0600 | [diff] [blame] | 653 | if args.dt: |
| 654 | dtb_fname = args.dt |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 655 | else: |
Simon Glass | f46732a | 2019-07-08 14:25:29 -0600 | [diff] [blame] | 656 | board = args.board |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 657 | if not board: |
| 658 | raise ValueError('Must provide a board to process (use -b <board>)') |
Simon Glass | f46732a | 2019-07-08 14:25:29 -0600 | [diff] [blame] | 659 | board_pathname = os.path.join(args.build_dir, board) |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 660 | dtb_fname = os.path.join(board_pathname, 'u-boot.dtb') |
Simon Glass | f46732a | 2019-07-08 14:25:29 -0600 | [diff] [blame] | 661 | if not args.indir: |
| 662 | args.indir = ['.'] |
| 663 | args.indir.append(board_pathname) |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 664 | |
| 665 | try: |
Simon Glass | f46732a | 2019-07-08 14:25:29 -0600 | [diff] [blame] | 666 | tout.Init(args.verbosity) |
| 667 | elf.debug = args.debug |
| 668 | cbfs_util.VERBOSE = args.verbosity > 2 |
| 669 | state.use_fake_dtb = args.fake_dtb |
Simon Glass | 55ab0b6 | 2021-03-18 20:25:06 +1300 | [diff] [blame] | 670 | |
| 671 | # Normally we replace the 'u-boot' etype with 'u-boot-expanded', etc. |
| 672 | # When running tests this can be disabled using this flag. When not |
| 673 | # updating the FDT in image, it is not needed by binman, but we use it |
| 674 | # for consistency, so that the images look the same to U-Boot at |
| 675 | # runtime. |
| 676 | use_expanded = not args.no_expanded |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 677 | try: |
Simon Glass | f46732a | 2019-07-08 14:25:29 -0600 | [diff] [blame] | 678 | tools.SetInputDirs(args.indir) |
| 679 | tools.PrepareOutputDir(args.outdir, args.preserve) |
| 680 | tools.SetToolPaths(args.toolpath) |
| 681 | state.SetEntryArgs(args.entry_arg) |
Simon Glass | 76f496d | 2021-07-06 10:36:37 -0600 | [diff] [blame] | 682 | state.SetThreads(args.threads) |
Simon Glass | 9230773 | 2018-07-06 10:27:40 -0600 | [diff] [blame] | 683 | |
Simon Glass | d3151ff | 2019-07-20 12:23:27 -0600 | [diff] [blame] | 684 | images = PrepareImagesAndDtbs(dtb_fname, args.image, |
Simon Glass | 55ab0b6 | 2021-03-18 20:25:06 +1300 | [diff] [blame] | 685 | args.update_fdt, use_expanded) |
Heiko Thiery | 6d45136 | 2022-01-06 11:49:41 +0100 | [diff] [blame] | 686 | |
Simon Glass | 76f496d | 2021-07-06 10:36:37 -0600 | [diff] [blame] | 687 | if args.test_section_timeout: |
| 688 | # Set the first image to timeout, used in testThreadTimeout() |
| 689 | images[list(images.keys())[0]].test_section_timeout = True |
Heiko Thiery | 6d45136 | 2022-01-06 11:49:41 +0100 | [diff] [blame] | 690 | invalid = False |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 691 | for image in images.values(): |
Heiko Thiery | 6d45136 | 2022-01-06 11:49:41 +0100 | [diff] [blame] | 692 | invalid |= ProcessImage(image, args.update_fdt, args.map, |
| 693 | allow_missing=args.allow_missing, |
| 694 | allow_fake_blobs=args.fake_ext_blobs) |
Simon Glass | bdb4031 | 2018-09-14 04:57:20 -0600 | [diff] [blame] | 695 | |
| 696 | # Write the updated FDTs to our output files |
Simon Glass | 5a30060 | 2019-07-20 12:23:29 -0600 | [diff] [blame] | 697 | for dtb_item in state.GetAllFdts(): |
Simon Glass | bdb4031 | 2018-09-14 04:57:20 -0600 | [diff] [blame] | 698 | tools.WriteFile(dtb_item._fname, dtb_item.GetContents()) |
| 699 | |
Simon Glass | adfb849 | 2021-11-03 21:09:18 -0600 | [diff] [blame] | 700 | if elf_params: |
| 701 | data = state.GetFdtForEtype('u-boot-dtb').GetContents() |
| 702 | elf.UpdateFile(*elf_params, data) |
| 703 | |
Heiko Thiery | 6d45136 | 2022-01-06 11:49:41 +0100 | [diff] [blame] | 704 | if invalid: |
Simon Glass | a820af7 | 2020-09-06 10:39:09 -0600 | [diff] [blame] | 705 | tout.Warning("\nSome images are invalid") |
Simon Glass | 748a1d4 | 2021-07-06 10:36:41 -0600 | [diff] [blame] | 706 | |
| 707 | # Use this to debug the time take to pack the image |
| 708 | #state.TimingShow() |
Simon Glass | 2574ef6 | 2016-11-25 20:15:51 -0700 | [diff] [blame] | 709 | finally: |
| 710 | tools.FinaliseOutputDir() |
| 711 | finally: |
| 712 | tout.Uninit() |
| 713 | |
| 714 | return 0 |