cmd: fpga: Cleanup error handling in connection to FPGA_NONE
Incorrect command is already handled and FPGA_NONE should be used only
one. In case of error CMD_RET_USAGE can be returned directly without any
addition logic around.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/cmd/fpga.c b/cmd/fpga.c
index de8505e..af2f514 100644
--- a/cmd/fpga.c
+++ b/cmd/fpga.c
@@ -171,11 +171,10 @@
if (dev == FPGA_INVALID_DEVICE) {
puts("FPGA device not specified\n");
- op = FPGA_NONE;
+ return CMD_RET_USAGE;
}
switch (op) {
- case FPGA_NONE:
case FPGA_INFO:
break;
#if defined(CONFIG_CMD_FPGA_LOADFS)
@@ -219,13 +218,10 @@
if (wrong_parms) {
puts("Wrong parameters for FPGA request\n");
- op = FPGA_NONE;
+ return CMD_RET_USAGE;
}
switch (op) {
- case FPGA_NONE:
- return CMD_RET_USAGE;
-
case FPGA_INFO:
rc = fpga_info(dev);
break;