commit f0426f69ddb4b2c719a99cedb759b0c747500b4d
author Eugeniu Rosca <roscaeugeniu@gmail.com> Sat Jul 14 22:53:32 2018 +0200
committer Alexander Graf <agraf@suse.de> Tue Aug 21 00:04:24 2018 +0200
tree a6bf782ca7bec7dfdc879fbd42b9135dfbcc9786
parent 4e4423331de1381247548f4e4d34bfa9351ffb28

cmd: efi: Clarify calculation precedence for '&' and '?'

Fix cppcheck complaint:
[cmd/efi.c:173]: (style) Clarify calculation precedence for '&' and '?'.

Fixes: f1a0bafb5802 ("efi: Add a command to display the memory map")
Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Alexander Graf <agraf@suse.de>

cmd/efi.c

diff --git a/cmd/efi.c b/cmd/efi.c
index 366a79a..919cb2f 100644
--- a/cmd/efi.c
+++ b/cmd/efi.c
@@ -173,7 +173,7 @@
 		bool first;
 		int j;
 
-		printf("%c%llx: ", attr & EFI_MEMORY_RUNTIME ? 'r' : ' ',
+		printf("%c%llx: ", (attr & EFI_MEMORY_RUNTIME) ? 'r' : ' ',
 		       attr & ~EFI_MEMORY_RUNTIME);
 		for (j = 0, first = true; j < ARRAY_SIZE(mem_attr); j++) {
 			if (attr & mem_attr[j].val) {