bcmgenet, sun8i_emac: Don't connect PHY two times
The bcmgenet and sun8i_emac drivers call phy_connect(), which finds /
creates the PHY and also connects it to the eth device via
phy_connect_dev(), then set some phydev members (bcmgenet only), and
then call phy_connect_dev() explicitly again.
Drop the second phy_connect_dev(), since it is unnecesary.
Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
diff --git a/drivers/net/bcmgenet.c b/drivers/net/bcmgenet.c
index ef321f2..4e1f8ed 100644
--- a/drivers/net/bcmgenet.c
+++ b/drivers/net/bcmgenet.c
@@ -526,8 +526,6 @@
}
phydev->advertising = phydev->supported;
- phy_connect_dev(phydev, dev);
-
priv->phydev = phydev;
phy_config(priv->phydev);
diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c
index 5943a5e..906a8ec 100644
--- a/drivers/net/sun8i_emac.c
+++ b/drivers/net/sun8i_emac.c
@@ -391,8 +391,6 @@
if (!phydev)
return -ENODEV;
- phy_connect_dev(phydev, dev);
-
priv->phydev = phydev;
phy_config(priv->phydev);