commit e087a4613eb8a7b202e3884af366b6e892ad7344
author Marek Behún <marek.behun@nic.cz> Thu Nov 04 00:23:22 2021 +0100
committer Simon Glass <sjg@chromium.org> Sat Nov 13 08:16:39 2021 -0700
tree 8c9dd382bdcc4d64b507b97f354f5e99f493601a
parent 08c6b04c301e5380ffdccd1d043fe558996aed3d

env: Fix env_get() when returning empty string using env_get_f()

The env_get_f() function returns -1 on failure. Returning 0 means that
the variable exists, and is empty string.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Simon Glass <sjg@chromium.org>

env/common.c

diff --git a/env/common.c b/env/common.c
index 2aa2354..757c5f9 100644
--- a/env/common.c
+++ b/env/common.c
@@ -125,7 +125,7 @@
 	}
 
 	/* restricted capabilities before import */
-	if (env_get_f(name, (char *)(gd->env_buf), sizeof(gd->env_buf)) > 0)
+	if (env_get_f(name, (char *)(gd->env_buf), sizeof(gd->env_buf)) >= 0)
 		return (char *)(gd->env_buf);
 
 	return NULL;