commit d54f0e734a7d5406c65b578dd0adbd98b512e90a
author Nathan Rossi <nathan@nathanrossi.com> Wed Dec 09 00:44:43 2015 +1000
committer Michal Simek <michal.simek@xilinx.com> Fri Dec 18 13:15:57 2015 +0100
tree 80d2d4efa5184aa768f9cbc5bba30478bea33e48
parent 4eeed0ea5f297a130765473ef3cd67bd96d5ce8e

tools: zynqimage: Clean up check_params

Clean up the param checking, removing some code paths that will never
happen.

Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Tom Rini <trini@konsulko.com>
Reported-by: Coverity (CID 133251)
Reviewed-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>

tools/zynqimage.c

diff --git a/tools/zynqimage.c b/tools/zynqimage.c
index 25f558d..c43bd5d 100644
--- a/tools/zynqimage.c
+++ b/tools/zynqimage.c
@@ -212,8 +212,7 @@
 		return -1;
 	}
 
-	return !((params->lflag || params->dflag) ||
-			(params->dflag && params->eflag));
+	return !(params->lflag || params->dflag);
 }
 
 static int zynqimage_check_image_types(uint8_t type)