commit c966354656d5ad47b3a77f723331e5dd2380a06d
author Eugeniu Rosca <roscaeugeniu@gmail.com> Tue Aug 14 02:43:08 2018 +0200
committer Tom Rini <trini@konsulko.com> Fri Aug 24 13:19:53 2018 -0400
tree 8ed5489f33ffa2a18be3860f1379f3a0be31b3c3
parent a5f012e8b26ed474ca71d672e0de1fbae35173c3

common: avb_verify: Fix never-occurring avb_free(ops_data)

Cppcheck (v1.85) reports w/o this patch:

[common/avb_verify.c:738] -> [common/avb_verify.c:741]: (warning) \
  Either the condition 'ops' is redundant or there is possible null \
  pointer dereference: ops.

Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Reviewed-by: Igor Opaniuk <igor.opaniuk@linaro.org>

common/avb_verify.c

diff --git a/common/avb_verify.c b/common/avb_verify.c
index 0bc1c23..0234f98 100644
--- a/common/avb_verify.c
+++ b/common/avb_verify.c
@@ -766,7 +766,7 @@
 {
 	struct AvbOpsData *ops_data;
 
-	if (ops)
+	if (!ops)
 		return;
 
 	ops_data = ops->user_data;