commit b4f950c37c41dc737cac5f50fca8c366abfce402
author Marek Behún <kabel@kernel.org> Tue May 21 09:13:28 2024 +0200
committer Tom Rini <trini@konsulko.com> Fri Jun 07 10:47:59 2024 -0600
tree 3c78bbceea393b3b5a119f33aadb5a2fff012ba6
parent 59193a72f1a77ff8712e72fb1c255b2d721ce4a3

common: eeprom_field: Drop unnecessary comparison

The byte variable is of type unsigned char, it is never less than zero.
The error case is handled by *endptr, so drop the comparison altogether.

Signed-off-by: Marek Behún <kabel@kernel.org>

common/eeprom/eeprom_field.c

diff --git a/common/eeprom/eeprom_field.c b/common/eeprom/eeprom_field.c
index 9b83141..26f6041 100644
--- a/common/eeprom/eeprom_field.c
+++ b/common/eeprom/eeprom_field.c
@@ -56,7 +56,7 @@
 		}
 
 		byte = simple_strtoul(tmp, &endptr, 16);
-		if (*endptr != '\0' || byte < 0)
+		if (*endptr != '\0')
 			return -1;
 
 		field->buf[j] = byte;