commit b2890a14de4d656a378f4b45d8248e70c2a4e929
author Simon Glass <sjg@chromium.org> Sun Mar 07 17:34:56 2021 -0700
committer Tom Rini <trini@konsulko.com> Fri Mar 12 09:57:30 2021 -0500
tree 7496d35d4a59e8e3bb34d35dc918c4d61c956565
parent 59cad96417b6d1881cd7cb6c3ddd5922b611f00e

test: Handle driver model reinit in test_pre_run()

For driver model tests we want to reinit the data structures so that
everything is in a known state before the test runs. This avoids one test
changing something that breaks a subsequent tests.

Move the call for this into test_pre_run().

Signed-off-by: Simon Glass <sjg@chromium.org>

include/test/test.h

diff --git a/include/test/test.h b/include/test/test.h
index d282cb23..6997568 100644
--- a/include/test/test.h
+++ b/include/test/test.h
@@ -15,6 +15,7 @@
  * @fail_count: Number of tests that failed
  * @start: Store the starting mallinfo when doing leak test
  * @priv: A pointer to some other info some suites want to track
+ * @of_live: true to use livetree if available, false to use flattree
  * @of_root: Record of the livetree root node (used for setting up tests)
  * @expect_str: Temporary string used to hold expected string value
  * @actual_str: Temporary string used to hold actual string value
@@ -24,6 +25,7 @@
 	struct mallinfo start;
 	void *priv;
 	struct device_node *of_root;
+	bool of_live;
 	char expect_str[256];
 	char actual_str[256];
 };

include/test/ut.h

diff --git a/include/test/ut.h b/include/test/ut.h
index e5ec18e..6e56ca9 100644
--- a/include/test/ut.h
+++ b/include/test/ut.h
@@ -388,6 +388,16 @@
 int test_post_run(struct unit_test_state *uts, struct unit_test *test);
 
 /**
+ * dm_test_init() - Get ready to run a driver model test
+ *
+ * This clears out the driver model data structures. For sandbox it resets the
+ * state structure.
+ *
+ * @uts: Test state
+ */
+int dm_test_init(struct unit_test_state *uts);
+
+/**
  * ut_run_tests() - Run a set of tests
  *
  * This runs the tests, handling any preparation and clean-up needed. It prints

test/dm/test-dm.c

diff --git a/test/dm/test-dm.c b/test/dm/test-dm.c
index 569ffbb..ceeac3f 100644
--- a/test/dm/test-dm.c
+++ b/test/dm/test-dm.c
@@ -24,10 +24,10 @@
 struct unit_test_state global_dm_test_state;
 static struct dm_test_state _global_priv_dm_test_state;
 
-/* Get ready for testing */
-static int dm_test_init(struct unit_test_state *uts, bool of_live)
+int dm_test_init(struct unit_test_state *uts)
 {
 	struct dm_test_state *dms = uts->priv;
+	bool of_live = uts->of_live;
 
 	memset(dms, '\0', sizeof(*dms));
 	gd->dm_root = NULL;
@@ -70,7 +70,7 @@
 
 	printf("Test: %s: %s%s\n", test->name, fname,
 	       !of_live ? " (flat tree)" : "");
-	ut_assertok(dm_test_init(uts, of_live));
+	uts->of_live = of_live;
 
 	ut_assertok(test_pre_run(uts, test));
 

test/test-main.c

diff --git a/test/test-main.c b/test/test-main.c
index 6f0d32f..f14b7b0 100644
--- a/test/test-main.c
+++ b/test/test-main.c
@@ -30,6 +30,9 @@
 
 int test_pre_run(struct unit_test_state *uts, struct unit_test *test)
 {
+	if (test->flags & UT_TESTF_DM)
+		ut_assertok(dm_test_init(uts));
+
 	ut_set_skip_delays(uts, false);
 
 	uts->start = mallinfo();