tree 8d2cf90e7e8af689f178237f068fcee64f274f28
parent fabe707def1a52de51c645c60c3b1189cfc41470
author Heinrich Schuchardt <heinrich.schuchardt@canonical.com> 1682994849 +0200
committer Tom Rini <trini@konsulko.com> 1685568181 -0400

cli: avoid buffer overrun

Invoking the sandbox with

    /u-boot -c ⧵0xef⧵0xbf⧵0xbd

results in a segmentation fault.

Function b_getch() retrieves a character from the input stream. This
character may be > 0x7f. If type char is signed, static_get() will
return a negative number and in parse_stream() we will use that
negative number as an index for array map[] resulting in a buffer
overflow.

Reported-by: Harry Lockyer <harry_lockyer@tutanota.com>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Simon Glass <sjg@chromium.org>