commit 9bac16742c73d2ad671e19cade0bace0eccb7f42
author Simon Glass <sjg@chromium.org> Sat Jan 22 05:07:32 2022 -0700
committer Tom Rini <trini@konsulko.com> Tue Feb 08 23:07:59 2022 -0500
tree 40193f2dffc5b43855175b7386af48dc12f6145d
parent 22901f9f59492d3d13b323f72e63f248c64026bc

buildman: Provide a hint on how to debug thread crashes

If a thread crashes it is helpful to try the operation again with
threading disabled. Add a hint about that.

Signed-off-by: Simon Glass <sjg@chromium.org>

tools/buildman/builderthread.py

diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
index 3e450e4..0faa3ac 100644
--- a/tools/buildman/builderthread.py
+++ b/tools/buildman/builderthread.py
@@ -557,6 +557,6 @@
             try:
                 self.RunJob(job)
             except Exception as e:
-                print('Thread exception:', e)
+                print('Thread exception (use -T0 to run without threads):', e)
                 self.builder.thread_exceptions.append(e)
             self.builder.queue.task_done()

tools/buildman/func_test.py

diff --git a/tools/buildman/func_test.py b/tools/buildman/func_test.py
index e09ccb7..c2e0b0b 100644
--- a/tools/buildman/func_test.py
+++ b/tools/buildman/func_test.py
@@ -623,4 +623,6 @@
         with test_util.capture_sys_output() as (stdout, stderr):
             self.assertEqual(102, self._RunControl('-o', self._output_dir,
                                                    test_thread_exceptions=True))
-        self.assertIn('Thread exception: test exception', stdout.getvalue())
+        self.assertIn(
+            'Thread exception (use -T0 to run without threads): test exception',
+            stdout.getvalue())