ram: rk3399: Add set_rate sdram rk3399 ops
DDR set rate can be even required for lpddr4 and we
need to keep the lpddr4 code to compile only for relevant
boards which do support lpddr4.
For this requirement, and for code readability handle
data training via sdram_rk3399_ops with .set_rate and
same will update in future while supporting lpddr4 code.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Reviewed-by: Kever Yang <Kever.yang@rock-chips.com>
diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
index fe79f31..d67123e 100644
--- a/drivers/ram/rockchip/sdram_rk3399.c
+++ b/drivers/ram/rockchip/sdram_rk3399.c
@@ -74,6 +74,8 @@
struct sdram_rk3399_ops {
int (*data_training)(struct dram_info *dram, u32 channel, u8 rank,
struct rk3399_sdram_params *sdram);
+ int (*set_rate)(struct dram_info *dram,
+ const struct rk3399_sdram_params *params);
};
#if defined(CONFIG_TPL_BUILD) || \
@@ -948,6 +950,7 @@
return 0;
}
+#if !defined(CONFIG_RAM_RK3399_LPDDR4)
static void select_per_cs_training_index(const struct chan_info *chan,
u32 rank)
{
@@ -1368,6 +1371,7 @@
return 0;
}
+#endif
static void set_ddrconfig(const struct chan_info *chan,
const struct rk3399_sdram_params *params,
@@ -1487,7 +1491,6 @@
return data_training(dram, channel, params, training_flag);
}
-#endif
static int switch_to_phy_index1(struct dram_info *dram,
const struct rk3399_sdram_params *params)
@@ -1534,7 +1537,8 @@
return 0;
}
-#if defined(CONFIG_RAM_RK3399_LPDDR4)
+#else
+
static u32 get_ddr_stride(struct rk3399_pmusgrf_regs *pmusgrf)
{
return ((readl(&pmusgrf->soc_con4) >> 10) & 0x1F);
@@ -1954,7 +1958,7 @@
params->base.stride = calculate_stride(params);
dram_all_config(dram, params);
- switch_to_phy_index1(dram, params);
+ dram->ops->set_rate(dram, params);
debug("Finish SDRAM initialization...\n");
return 0;
@@ -2002,6 +2006,7 @@
static const struct sdram_rk3399_ops rk3399_ops = {
#if !defined(CONFIG_RAM_RK3399_LPDDR4)
.data_training = default_data_training,
+ .set_rate = switch_to_phy_index1,
#else
.data_training = lpddr4_mr_detect,
#endif