tree 5e79be38ff31b24fe389d45b082f651682dd9657
parent c828253217bc502cafc2655f110f55c8da892a55
author Jon Povey <jon.povey@racelogic.co.uk> 1299820256 +0900
committer Wolfgang Denk <wd@denx.de> 1303338308 +0200

tools/env: fix redundant env flag comparison

This fixes two bugs with comparison of redundant environment flags on
read.

flag0 and flag1 in fw_env_open() were declared signed instead of
unsigned char breaking BOOLEAN mode "== 0xFF" tests and in INCREMENTAL
mode the wrong environment would be chosen where the flag values are
127 and 128 (either way round). With both flags over 128, both signs
flipped and the logic worked by happy accident.

Also there was a logic bug in the INCREMENTAL test (after signedness was
fixed) in the case flag0=0, flag1=255, env 1 would be incorrectly chosen.

Fix both of these.

Signed-off-by: Jon Povey <jon.povey@racelogic.co.uk>