usb: xhci-dwc3: Power on USB PHY before using
It is wrong that expect .phy_init() to also power on the PHY. Therefore,
explicitly, call generic_phy_power_on() after generic_phy_power_init() in
order to power on PHY before using it.
Signed-off-by: Vignesh R <vigneshr@ti.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff --git a/drivers/usb/host/xhci-dwc3.c b/drivers/usb/host/xhci-dwc3.c
index 258d1cd..cf1986b 100644
--- a/drivers/usb/host/xhci-dwc3.c
+++ b/drivers/usb/host/xhci-dwc3.c
@@ -137,6 +137,12 @@
pr_err("Can't init USB PHY for %s\n", dev->name);
return ret;
}
+
+ ret = generic_phy_power_on(&plat->usb_phy);
+ if (ret) {
+ pr_err("Can't power on USB PHY for %s\n", dev->name);
+ return ret;
+ }
}
dwc3_reg = (struct dwc3 *)((char *)(hccr) + DWC3_REG_OFFSET);
@@ -159,6 +165,12 @@
int ret;
if (generic_phy_valid(&plat->usb_phy)) {
+ ret = generic_phy_power_off(&plat->usb_phy);
+ if (ret) {
+ pr_err("Can't poweroff USB PHY for %s\n", dev->name);
+ return ret;
+ }
+
ret = generic_phy_exit(&plat->usb_phy);
if (ret) {
pr_err("Can't deinit USB PHY for %s\n", dev->name);