tree 6d30471b538ed5718134a24220e6b7ccb20c2908
parent 25fa8603a2093e82acb9f03552f2c7889c88dc5c
author Thomas Huth <huth@tuxfamily.org> 1440515380 +0200
committer Tom Rini <trini@konsulko.com> 1445709030 -0400

Fix bad return value checks (detected with Coccinelle)

In the "Getting Started with Coccinelle - KVM edition" presentation that
has been held by Julia Lawall at the KVM forum 2015 (see the slides at
http://events.linuxfoundation.org/sites/events/files/slides/tutorial_kvm_0.pdf),
she pointed out some bad return value checks in U-Boot that can be
detected with Coccinelle by using the following config file:

@@
identifier x,y;
identifier f;
statement S;
@@
x = f(...);
(
 if (x < 0) S
|
 if (
-     y
+     x
 < 0) S
)

This patch now fixes these issues.

Signed-off-by: Thomas Huth <huth@tuxfamily.org>