commit 7799081a04642395e5b62e8d46f9787e72c8ea69
author Ramon Fried <rfried.dev@gmail.com> Wed Jul 31 11:04:26 2019 +0300
committer Tom Rini <trini@konsulko.com> Wed Aug 07 15:31:04 2019 -0400
tree 8ce590165e09c5f87488b7b2bf31eade84a76f23
parent a588d1565d432effe10e93982ecef976b6644aa7

pci_ep: Fix Coverity warning

Fix the following Coverity warning:
CID 244086:  Incorrect expression  (BAD_COMPARE)
Comparing pointer "ep_bar" against NULL using anything besides == or
is likely to be incorrect.

Fixes: 914026d25848 ("drivers: pci_ep: Introduce UCLASS_PCI_EP uclass")

Signed-off-by: Ramon Fried <rfried.dev@gmail.com>

drivers/pci_endpoint/pci_ep-uclass.c

diff --git a/drivers/pci_endpoint/pci_ep-uclass.c b/drivers/pci_endpoint/pci_ep-uclass.c
index 2f9c703..9f53a9a 100644
--- a/drivers/pci_endpoint/pci_ep-uclass.c
+++ b/drivers/pci_endpoint/pci_ep-uclass.c
@@ -43,7 +43,7 @@
 	int flags = ep_bar->flags;
 
 	/* Some basic bar validity checks */
-	if (ep_bar->barno > BAR_5 || ep_bar < BAR_0)
+	if (ep_bar->barno > BAR_5 || ep_bar->barno < BAR_0)
 		return -EINVAL;
 
 	if ((ep_bar->barno == BAR_5 &&