commit 7188e4b567fc84cd8aaa2401bef496d495c86f89
author Simon Glass <sjg@chromium.org> Wed Jul 19 17:48:20 2023 -0600
committer Simon Glass <sjg@chromium.org> Mon Jul 24 09:34:10 2023 -0600
tree 3aab2fcb49ea690689b37fd2dfce4918e9428623
parent 9b828ec06e382707f4692908235e8ce4521c4d36

buildman: Refactor target handling in Boards.scan()

Move the assert to the top of the function and provide an explicit
variables for the target name and base name.

Signed-off-by: Simon Glass <sjg@chromium.org>

tools/buildman/boards.py

diff --git a/tools/buildman/boards.py b/tools/buildman/boards.py
index 122fe70..2d39326 100644
--- a/tools/buildman/boards.py
+++ b/tools/buildman/boards.py
@@ -231,6 +231,10 @@
                 'config': <config_header_name>,
             }
         """
+        leaf = os.path.basename(defconfig)
+        expect_target, match, rear = leaf.partition('_defconfig')
+        assert match and not rear, f'{leaf} : invalid defconfig'
+
         self._conf.load_config(defconfig)
         self._tmpfile = None
 
@@ -245,9 +249,7 @@
             else:
                 params[key] = '-'
 
-        defconfig = os.path.basename(defconfig)
-        params['target'], match, rear = defconfig.partition('_defconfig')
-        assert match and not rear, f'{defconfig} : invalid defconfig'
+        params['target'] = expect_target
 
         # fix-up for aarch64
         if params['arch'] == 'arm' and params['cpu'] == 'armv8':