commit 5a3b8dce8e5db168a5a7230b98ac1cca9aa7e6c5
author Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Sat Jan 15 20:12:56 2022 +0100
committer Tom Rini <trini@konsulko.com> Mon Jan 24 10:35:10 2022 -0500
tree a45f95eddd0481052a20027013e5ad96e5fd8c1a
parent 61f9b299f7e88e5febbe99ef761618a4b34748d7

mkimage: struct stat.st_size may not be long

The component st_size of struct stat is of type off_t. Depending on the
system printing it using %ld leads to a warning:

tools/mkimage.c:438:54: warning: format '%ld' expects argument of type
'long int', but argument 5 has type
'off_t' {aka 'long long int'} [-Wformat=]
  438 |     "%s: Bad size: \"%s\" is not valid image: size %ld < %u\n",
      |                                                    ~~^
      |                                                      |
      |                                                      long int
      |                                                    %lld

When comparing an off_t value to a 32bit integer we should not convert to
uint32_t but to off_t which may be wider.

Reported-by: Milan P. Stanić <mps@arvanta.net>
Fixes: 331f0800f1a3 ("mkimage: allow -l to work on block devices on Linux")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Mark Kettenis <kettenis@openbsd.org>