commit 529d4fd90c5b7b06a0d180ea338a052b2bcf29c7
author Peng Fan <van.freenix@gmail.com> Tue May 03 10:24:52 2016 +0800
committer Marek Vasut <marex@denx.de> Fri May 06 20:06:56 2016 +0200
tree e3da0f8e08b8a27a097bfae31c694eb32dba5d67
parent c526e8322f1f0e1a6af627933031ce93cdbb12da

dfu: avoid memory leak

When dfu_fill_entity fail, need to free dfu to avoid memory leak.

Reported by Coverity:
"
Resource leak (RESOURCE_LEAK)
leaked_storage: Variable dfu going out of scope leaks the storage
it points to.
"

Signed-off-by: Peng Fan <van.freenix@gmail.com>
Cc: "Łukasz Majewski" <l.majewski@samsung.com>
Cc: Marek Vasut <marex@denx.de>

drivers/dfu/dfu.c

diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
index 8f5915e..20dfcbb 100644
--- a/drivers/dfu/dfu.c
+++ b/drivers/dfu/dfu.c
@@ -468,8 +468,10 @@
 		s = strsep(&env, ";");
 		ret = dfu_fill_entity(&dfu[i], s, alt_num_cnt, interface,
 				      devstr);
-		if (ret)
+		if (ret) {
+			free(dfu);
 			return -1;
+		}
 
 		list_add_tail(&dfu[i].list, &dfu_list);
 		alt_num_cnt++;