commit 47d9599a4f1812bd3896172d4fad7f1f1a144310
author Martyn Welch <martyn.welch@collabora.com> Sat Jan 26 02:31:50 2019 +0000
committer Tom Rini <trini@konsulko.com> Fri Feb 01 14:13:45 2019 -0500
tree 0d25820b20bed1088413fd87a29d84ce0b018a64
parent 73d55e560d192f7d012e4c257b673c79d1e385ad

tools: dumpimage: Provide more feedback on error

The dumpimage utility errors out in a number of places without providing
sufficient feedback to allow the user to easily determine what they have
done wrong. Add addtional error messages to make the cause of the failure
more obvious.

Signed-off-by: Martyn Welch <martyn.welch@collabora.com>

tools/dumpimage.c

diff --git a/tools/dumpimage.c b/tools/dumpimage.c
index 7115df0..2847e6c 100644
--- a/tools/dumpimage.c
+++ b/tools/dumpimage.c
@@ -80,6 +80,8 @@
 		case 'T':
 			params.type = genimg_get_type_id(optarg);
 			if (params.type < 0) {
+				fprintf(stderr, "%s: Invalid type\n",
+					params.cmdname);
 				usage();
 			}
 			break;
@@ -101,8 +103,10 @@
 		}
 	}
 
-	if (optind >= argc)
+	if (optind >= argc) {
+		fprintf(stderr, "%s: image file missing\n", params.cmdname);
 		usage();
+	}
 
 	/* set tparams as per input type_id */
 	tparams = imagetool_get_type(params.type);
@@ -117,8 +121,11 @@
 	 * as per image type to be generated/listed
 	 */
 	if (tparams->check_params) {
-		if (tparams->check_params(&params))
+		if (tparams->check_params(&params)) {
+			fprintf(stderr, "%s: Parameter check failed\n",
+				params.cmdname);
 			usage();
+		}
 	}
 
 	if (params.iflag)