patman: Support checking for review tags in patchwork
Before sending out a new version of a series for review, it is important
to add any review tags (e.g. Reviewed-by, Acked-by) collected by
patchwork. Otherwise people waste time reviewing the same patch
repeatedly, become frustrated and stop reviewing your patches.
To help with this, add a new 'status' subcommand that checks patchwork
for review tags, showing those which are not present in the local branch.
This allows users to see what new review tags have been received and then
add them.
Sample output:
$ patman status
1 Subject 1
Reviewed-by: Joe Bloggs <joe@napierwallies.co.nz>
2 Subject 2
Tested-by: Lord Edmund Blackaddër <weasel@blackadder.org>
Reviewed-by: Fred Bloggs <f.bloggs@napier.net>
+ Reviewed-by: Mary Bloggs <mary@napierwallies.co.nz>
1 new response available in patchwork
The '+' indicates a new tag. Colours are used to make it easier to read.
Signed-off-by: Simon Glass <sjg@chromium.org>
diff --git a/tools/patman/terminal.py b/tools/patman/terminal.py
index 60dbce3..9be03b3 100644
--- a/tools/patman/terminal.py
+++ b/tools/patman/terminal.py
@@ -34,14 +34,22 @@
newline: True to output a newline after the text
colour: Text colour to use
"""
- def __init__(self, text, newline, colour):
+ def __init__(self, text, colour, newline=True, bright=True):
self.text = text
self.newline = newline
self.colour = colour
+ self.bright = bright
+
+ def __eq__(self, other):
+ return (self.text == other.text and
+ self.newline == other.newline and
+ self.colour == other.colour and
+ self.bright == other.bright)
def __str__(self):
- return 'newline=%s, colour=%s, text=%s' % (self.newline, self.colour,
- self.text)
+ return ("newline=%s, colour=%s, bright=%d, text='%s'" %
+ (self.newline, self.colour, self.bright, self.text))
+
def CalcAsciiLen(text):
"""Calculate the length of a string, ignoring any ANSI sequences
@@ -136,7 +144,7 @@
global last_print_len
if print_test_mode:
- print_test_list.append(PrintLine(text, newline, colour))
+ print_test_list.append(PrintLine(text, colour, newline, bright))
else:
if colour:
col = Color()
@@ -159,11 +167,12 @@
print('\r%s\r' % (' '* last_print_len), end='', flush=True)
last_print_len = None
-def SetPrintTestMode():
+def SetPrintTestMode(enable=True):
"""Go into test mode, where all printing is recorded"""
global print_test_mode
- print_test_mode = True
+ print_test_mode = enable
+ GetPrintTestLines()
def GetPrintTestLines():
"""Get a list of all lines output through Print()