commit 35b82a8b07580bfec735c7faee96316ce0ef8f8e
author Adam Ford <aford173@gmail.com> Sat Feb 19 17:08:43 2022 -0600
committer Marek Vasut <marex@denx.de> Wed Feb 23 05:25:17 2022 +0100
tree 3963f92e3020498b17fc38f6aa0bb2a01b9a3e29
parent 3ca17c4e9abb40f9b216ff1fc66721a759c6398e

phy: nop-phy: Fix enabling reset

The reset function should place the phy into reset, while the
init function should take the phy out of reset.  Currently the
reset function takes it out of reset, and the init calls the
reset.

Signed-off-by: Adam Ford <aford173@gmail.com>

drivers/phy/nop-phy.c

diff --git a/drivers/phy/nop-phy.c b/drivers/phy/nop-phy.c
index b08eedd..e2ee6e9 100644
--- a/drivers/phy/nop-phy.c
+++ b/drivers/phy/nop-phy.c
@@ -28,7 +28,7 @@
 	if (!dm_gpio_is_valid(&priv->reset_gpio))
 		return 0;
 
-	return dm_gpio_set_value(&priv->reset_gpio, false);
+	return dm_gpio_set_value(&priv->reset_gpio, true);
 }
 #endif
 
@@ -44,7 +44,8 @@
 	}
 
 #if CONFIG_IS_ENABLED(DM_GPIO)
-	ret = nop_phy_reset(phy);
+	/* Take phy out of reset */
+	ret = dm_gpio_set_value(&priv->reset_gpio, false);
 	if (ret) {
 		if (CONFIG_IS_ENABLED(CLK))
 			clk_disable_bulk(&priv->bulk);