firmware: scmi: factorize scmi transport look up
Defines local helper function find_scmi_transport_device() with the
instructions to find the SCMI transport device from a SCMI protocol
device.
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
diff --git a/drivers/firmware/scmi/scmi_agent-uclass.c b/drivers/firmware/scmi/scmi_agent-uclass.c
index c9c9c00..f7fa5df 100644
--- a/drivers/firmware/scmi/scmi_agent-uclass.c
+++ b/drivers/firmware/scmi/scmi_agent-uclass.c
@@ -109,6 +109,20 @@
return ret;
}
+static struct udevice *find_scmi_transport_device(struct udevice *dev)
+{
+ struct udevice *parent = dev;
+
+ do {
+ parent = dev_get_parent(parent);
+ } while (parent && device_get_uclass_id(parent) != UCLASS_SCMI_AGENT);
+
+ if (!parent)
+ dev_err(dev, "Invalid SCMI device, agent not found\n");
+
+ return parent;
+}
+
static const struct scmi_agent_ops *transport_dev_ops(struct udevice *dev)
{
return (const struct scmi_agent_ops *)dev->driver->ops;
@@ -118,17 +132,11 @@
struct scmi_msg *msg)
{
const struct scmi_agent_ops *ops;
- struct udevice *parent = dev;
-
- /* Find related SCMI agent device */
- do {
- parent = dev_get_parent(parent);
- } while (parent && device_get_uclass_id(parent) != UCLASS_SCMI_AGENT);
+ struct udevice *parent;
- if (!parent) {
- dev_err(dev, "Invalid SCMI device, agent not found\n");
+ parent = find_scmi_transport_device(dev);
+ if (!parent)
return -ENODEV;
- }
ops = transport_dev_ops(parent);