commit 2e0bf3f4d7e710d0b92d46539b3fcb4cb95f8ebf
author Simon Glass <sjg@chromium.org> Sun Jun 18 22:09:04 2017 -0600
committer Simon Glass <sjg@chromium.org> Tue Jul 11 10:08:20 2017 -0600
tree 30ee6e85b2f5066d101ae90d3778d406a0bfa729
parent 3fa797a1eb715ad0443f4c844456dad14c5d6ab8

dtoc: Add a comment about string replace in conv_name_to_c()

This function uses several separate string replaces where a regular
expression might seem more reasonable. Add a comment justifying the way it
is currently done.

Signed-off-by: Simon Glass <sjg@chromium.org>

tools/dtoc/dtb_platdata.py

diff --git a/tools/dtoc/dtb_platdata.py b/tools/dtoc/dtb_platdata.py
index 9923892..1f85343 100644
--- a/tools/dtoc/dtb_platdata.py
+++ b/tools/dtoc/dtb_platdata.py
@@ -46,6 +46,9 @@
 def conv_name_to_c(name):
     """Convert a device-tree name to a C identifier
 
+    This uses multiple replace() calls instead of re.sub() since it is faster
+    (400ms for 1m calls versus 1000ms for the 're' version).
+
     Args:
         name:   Name to convert
     Return: