tree 5a7ac46953540a4c8430cceb2a8caf85bf8d7950
parent ca8d72ed860d4a9e8777ce3275e25c3974023d38
author Vladimir Oltean <vladimir.oltean@nxp.com> 1632741704 +0300
committer Ramon Fried <rfried.dev@gmail.com> 1632844256 +0300

net: at91_emac: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

strncpy() simply bails out when copying a source string whose size
exceeds the destination string size, potentially leaving the destination
string unterminated.

One possible way to address is to pass MDIO_NAME_LEN - 1 and a
previously zero-initialized destination string, but this is more
difficult to maintain.

The chosen alternative is to use strlcpy(), which properly limits the
copy len in the (srclen >= size) case to "size - 1", and which is also
more efficient than the strncpy() byte-by-byte implementation by using
memcpy. The destination string returned by strlcpy() is always NULL
terminated.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>