commit 3042373b5a63cf8720aa3e759b10cd7545746864
author developer <developer@mediatek.com> Thu Dec 01 16:17:49 2022 +0800
committer developer <developer@mediatek.com> Fri Dec 02 14:55:57 2022 +0800
tree 3de29ad524dab7e59d9e101c90a627db174c81d8
parent 40a11cb6bc3791ffa076ef4221e8af7abb158b06

[rdkb][common][hal][Fix some bugs warning by coverity]

[Description]
Fix some bugs warning by coverity.
1. Fix TOCTOU(Time of check, time of use).
2. Add initializaion of struct and string.
3. Fix printf arguments.
4. Fix deadcode for if clausure.
5. Fix BAD_COMPARE.
6. Fix ALLOC_FREE_MISMATCH.
7. Fix DIVIDE_BY_ZERO by adding check.

[Release-log]
N/A

Change-Id: I8105287c7e586efe396400e85621c76ba08966e2

src/wifi/client_wifi_hal.c

diff --git a/src/wifi/client_wifi_hal.c b/src/wifi/client_wifi_hal.c
index e6301d9..b837997 100644
--- a/src/wifi/client_wifi_hal.c
+++ b/src/wifi/client_wifi_hal.c
@@ -574,7 +574,7 @@
             if(id >= out_array_size)
                 goto close;
             staNetwork++;
-            }
+        }
     }
 close:
     fclose(fd);
@@ -602,11 +602,7 @@
     if (ret != RETURN_OK)
         return RETURN_ERR;
     snprintf(fname, sizeof(fname), "/nvram/%s.conf", ssid_ifname);
-    if (access(fname, F_OK) != 0) {
-        sprintf(cmd, "touch %s", fname);
-        _syscmd(cmd, out, sizeof(out));
-    }
-    sprintf(cmd, "cp %s /nvram/%s.old", fname, ssid_ifname);
+    sprintf(cmd, "touch %s && cp %s /nvram/%s.old", fname, fname, ssid_ifname);
     _syscmd(cmd, out, 64);
 
     fd = fopen(fname, "w");
@@ -713,7 +709,7 @@
     wifi_getSTARadioIndex(ssidIndex, &radioIndex);
     phyIndex = radio_index_to_phy(radioIndex);
     if (phyIndex == -1) {
-        fprintf(stderr, "%s: Invalid radio index %d.\n", radioIndex);
+        fprintf(stderr, "%s: Invalid radio index %d.\n", __func__, radioIndex);
         return RETURN_ERR;
     }
     snprintf(cmd, sizeof(cmd), "iw phy phy%d interface add %s type managed 4addr on", phyIndex, ssid_ifname);